Skip to content

[pytest/lacp]: use lacp timer if lacp rate cmd is not available#2488

Merged
lguohan merged 1 commit intosonic-net:masterfrom
lguohan:lacp
Nov 10, 2020
Merged

[pytest/lacp]: use lacp timer if lacp rate cmd is not available#2488
lguohan merged 1 commit intosonic-net:masterfrom
lguohan:lacp

Conversation

@lguohan
Copy link
Contributor

@lguohan lguohan commented Nov 8, 2020

Description of PR

Summary:
Fixes #2041

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

eos has deprecated lacp rate cmd in latest eos

Signed-off-by: Guohan Lu [email protected]

How did you do it?

use lacp timer if lacp rate cmd is not available

How did you verify/test it?

lgh@54edb99ee27f:/var/src/sonic-mgmt/tests$ ./run_tests.sh -i veos_vtb -d vlab-01 -n vms-kvm-t0 -f vtestbed.csv -k debug -l warning -m individual -q 1 -a False -e --disable_loganalyzer -u -c pc/test_lag_2.py -p logs
=== Running tests individually ===
/usr/local/lib/python2.7/dist-packages/ansible/parsing/vault/__init__.py:44: CryptographyDeprecationWarning: Python 2 is no longer supported by the Python core team. Support for it is now deprecated in cryptography, and will be removed in a future release.
  from cryptography.exceptions import InvalidSignature
================================================================================================= test session starts ==================================================================================================
platform linux2 -- Python 2.7.17, pytest-4.6.5, py-1.9.0, pluggy-0.13.1
ansible: 2.8.12
rootdir: /var/src/sonic-mgmt/tests, inifile: pytest.ini
plugins: forked-1.3.0, xdist-1.28.0, metadata-1.10.0, html-1.22.1, repeat-0.8.0, ansible-2.2.2
collected 3 items                                                                                                                                                                                                      

pc/test_lag_2.py::test_lag[unknown|unknown-single_lag] PASSED                                                                                                                                                    [ 33%]
pc/test_lag_2.py::test_lag[unknown|unknown-lacp_rate] PASSED                                                                                                                                                     [ 66%]
pc/test_lag_2.py::test_lag[unknown|unknown-fallback] SKIPPED                                                                                                                                                     [100%]

------------------------------------------------------------------------- generated xml file: /var/src/sonic-mgmt/tests/logs/pc/test_lag_2.xml -------------------------------------------------------------------------
=============================================================================================== short test summary info ================================================================================================
SKIPPED [1] /var/src/sonic-mgmt/tests/common/helpers/assertions.py:13: Skip fallback for lag PortChannel0001 due to fallback was not set for it
======================================================================================== 2 passed, 1 skipped in 1041.82 seconds ========================================================================================
lgh@54edb99ee27f:/var/src/sonic-mgmt/tests$ 

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

eos has deprecated lacp rate cmd in latest eos

Signed-off-by: Guohan Lu <[email protected]>
@lguohan lguohan requested a review from yxieca November 8, 2020 09:57
@lguohan lguohan linked an issue Nov 8, 2020 that may be closed by this pull request
@lguohan lguohan linked an issue Nov 8, 2020 that may be closed by this pull request
@lguohan lguohan merged commit 5dcdb48 into sonic-net:master Nov 10, 2020
@lguohan lguohan deleted the lacp branch November 10, 2020 00:57
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…nic-net#12669)

utilities:
* 8cb6124 2022-11-09 | [armhf][sonic-installer] Fix the issue of sonic-installer list after set-default and cleanup (sonic-net#2479) [Marty Y. Lok]
* b2d50f4 2022-11-06 | [GCU] Fix JsonPointerFilter bug (sonic-net#2477) (HEAD -> 202205, github/202205) [jingwenxie]
* 927daea 2022-11-08 | Do not configure physical attributes on port channels in portconfig (sonic-net#2456) [Stephen Sun]
* dbe8f2d 2022-11-02 | Fix sudo sfputil show error-status on a multiasic platform issue (sonic-net#2373) [Marty Y. Lok]
* fff5f67 2022-11-04 | [show] vnet advertised-route command (sonic-net#2390) (sonic-net#2478) [siqbal1986]
* 9d921a7 2022-11-04 | Fix exception in adding mirror_session when gre_type is absent (sonic-net#2476) [bingwang-ms]
* 0bbe54a 2022-11-03 | [show] vnet endpoint [ip/ipv6] command (sonic-net#2342) (sonic-net#2421) (sonic-net#2474) [siqbal1986]
* b1b3661 2022-11-03 | show vnet routes all. (sonic-net#2341) (sonic-net#2472) [siqbal1986]

swss:
* e208c87 2022-11-08 | swss: Fixing race condition for rif counters (sonic-net#2488) (HEAD -> 202205) [Suman Kumar]

platform-common:
* 83f77cc 2022-11-08 | Fix issue: rounding float value for txpower and rxpower (sonic-net#320) (HEAD -> 202205) [Junchao-Mellanox]
* 169ee25 2022-11-04 | Fix issue: copper cable should not display DOM information (sonic-net#318) [Junchao-Mellanox]

Signed-off-by: Ying Xie <[email protected]>

Signed-off-by: Ying Xie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sonic-mgmt/tests/pc/test_lag_2.py failed since EOS CLI incorrectly set about lacp mode pc/test_lag_2.py failed on virtual testbed t0

2 participants