[kvm/docs] Improve KVM setup instructions#2476
Merged
daall merged 2 commits intosonic-net:masterfrom Nov 6, 2020
Merged
Conversation
Signed-off-by: Danny Allen <daall@microsoft.com>
yxieca
approved these changes
Nov 6, 2020
Contributor
|
retest this please |
lguohan
approved these changes
Nov 6, 2020
lguohan
reviewed
Nov 6, 2020
prsunny
reviewed
Mar 23, 2021
| echo | ||
|
|
||
| echo "STEP 5: Checking if bridge br1 already exists..." | ||
| if ! brctl show br1; then |
Contributor
There was a problem hiding this comment.
If it returns the output as below, then this step fails. May be we should just add br1 even if it exists..
STEP 5: Checking if bridge br1 already exists...
bridge name bridge id STP enabled interfaces
br1 can't get info No such device
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…nic-net#12669) utilities: * 8cb6124 2022-11-09 | [armhf][sonic-installer] Fix the issue of sonic-installer list after set-default and cleanup (sonic-net#2479) [Marty Y. Lok] * b2d50f4 2022-11-06 | [GCU] Fix JsonPointerFilter bug (sonic-net#2477) (HEAD -> 202205, github/202205) [jingwenxie] * 927daea 2022-11-08 | Do not configure physical attributes on port channels in portconfig (sonic-net#2456) [Stephen Sun] * dbe8f2d 2022-11-02 | Fix sudo sfputil show error-status on a multiasic platform issue (sonic-net#2373) [Marty Y. Lok] * fff5f67 2022-11-04 | [show] vnet advertised-route command (sonic-net#2390) (sonic-net#2478) [siqbal1986] * 9d921a7 2022-11-04 | Fix exception in adding mirror_session when gre_type is absent (sonic-net#2476) [bingwang-ms] * 0bbe54a 2022-11-03 | [show] vnet endpoint [ip/ipv6] command (sonic-net#2342) (sonic-net#2421) (sonic-net#2474) [siqbal1986] * b1b3661 2022-11-03 | show vnet routes all. (sonic-net#2341) (sonic-net#2472) [siqbal1986] swss: * e208c87 2022-11-08 | swss: Fixing race condition for rif counters (sonic-net#2488) (HEAD -> 202205) [Suman Kumar] platform-common: * 83f77cc 2022-11-08 | Fix issue: rounding float value for txpower and rxpower (sonic-net#320) (HEAD -> 202205) [Junchao-Mellanox] * 169ee25 2022-11-04 | Fix issue: copper cable should not display DOM information (sonic-net#318) [Junchao-Mellanox] Signed-off-by: Ying Xie <ying.xie@microsoft.com> Signed-off-by: Ying Xie <ying.xie@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen daall@microsoft.com
Description of PR
Summary: Improve KVM setup instructions
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
I received some feedback while helping people onboard to the KVM testbed:
ethtoolinstalled by default, which can cause some strange errors.sonic-mgmtinside the docker container.How did you do it?
ethtoolto the setup script.sonic-mgmt.bgp_facttest.How did you verify/test it?
Verified that the
setupscripts work as described, and are idempotent.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation