[Test Gap] Add test to validate GCU apply-patch completes within expected time bounds#23847
Open
rimunagala wants to merge 1 commit into
Open
[Test Gap] Add test to validate GCU apply-patch completes within expected time bounds#23847rimunagala wants to merge 1 commit into
rimunagala wants to merge 1 commit into
Conversation
Collaborator
|
/azp run |
github-actions
Bot
requested review from
isabelmsft,
xincunli-sonic and
yutongzhang-microsoft
|
Azure Pipelines successfully started running 1 pipeline(s). |
rimunagala
force-pushed
the
test-gap/gcu-acl-ports-replace
branch
from
d09d375 to
6c6d7c8
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
guangyao6
pushed a commit
to guangyao6/sonic-mgmt
that referenced
this pull request
Apr 16, 2026
…onic-net#20448) Summary: Fixes sonic-net#23847 How did you verify/test it? RAn test generic_config_updater.test_eth_interface::test_replace_fec
…cted time bounds Signed-off-by: Rithvick Reddy Munagala <rimunagala@microsoft.com>
rimunagala
force-pushed
the
test-gap/gcu-acl-ports-replace
branch
from
6c6d7c8 to
d32c9a7
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Apr 20, 2026
…onic-net#20448) Summary: Fixes sonic-net#23847 How did you verify/test it? RAn test generic_config_updater.test_eth_interface::test_replace_fec Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Adds a new test case to cover the GCU hang/slowness regression where
replacing a large ACL ports list with a much smaller one causes GCU's
internal sort/diff logic to hang.
Fixes #23845
Type of change
Back port request
Approach
What is the motivation for this PR?
GCU has no test that verifies apply-patch completes within a reasonable
time when processing config changes. GCU performance regressions - including
near-hung behavior - go completely undetected in CI.
How did you do it?
Added test_gcu_acl_ports_replace_large_to_small in
tests/generic_config_updater/test_gcu_acl_ports_replace.py that:
How did you verify/test it?
Any platform specific information?
No - uses topology 'any'
Supported testbed topology if it's a new test case?
any
Documentation
N/A