Skip to content

[GCU] Adding namespace in config interface command for multi-asic support#20448

Merged
arlakshm merged 1 commit intosonic-net:masterfrom
okaravasi:master-gcu_test_replace_fec_add_namespace_arg
Oct 28, 2025
Merged

[GCU] Adding namespace in config interface command for multi-asic support#20448
arlakshm merged 1 commit intosonic-net:masterfrom
okaravasi:master-gcu_test_replace_fec_add_namespace_arg

Conversation

@okaravasi
Copy link
Contributor

Description of PR

Summary:
Fixes #23847

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

RAn test generic_config_updater.test_eth_interface::test_replace_fec

Any platform specific information?

multi-asic

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LinJin23
Copy link
Contributor

LinJin23 commented Oct 3, 2025

/Azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LinJin23
Copy link
Contributor

LinJin23 commented Oct 3, 2025

Hi @okaravasi, could you take a look at the CI failures?

@okaravasi
Copy link
Contributor Author

Hi @okaravasi, could you take a look at the CI failures?

Hi @LinJin23 Pipeline failures are not related with PR changes. It fails in "Prepare sonic-mgmt docker container" step. Please try to re-run them, I don't have access to do that.

@LinJin23
Copy link
Contributor

LinJin23 commented Oct 7, 2025

/Azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

Copy link
Contributor

@Javier-Tan Javier-Tan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had the same solution in store for this, LGTM

@Javier-Tan
Copy link
Contributor

/Azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LinJin23
Copy link
Contributor

The code changes look fine to me. but since this test is already skipped in #20542, why is this update still needed?

@LinJin23
Copy link
Contributor

/Azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Javier-Tan
Copy link
Contributor

The code changes look fine to me. but since this test is already skipped in #20542, why is this update still needed?

@LinJin23 that skip is only for specific Nokia SKUs and not multi-asic in general

@arlakshm arlakshm merged commit d2e2bf1 into sonic-net:master Oct 28, 2025
22 of 23 checks passed
dcaugher pushed a commit to dcaugher/sonic-mgmt that referenced this pull request Nov 12, 2025
…onic-net#20448)

Summary:
Fixes #23847

How did you verify/test it?
RAn test generic_config_updater.test_eth_interface::test_replace_fec
dcaugher pushed a commit to dcaugher/sonic-mgmt that referenced this pull request Nov 12, 2025
…onic-net#20448)

Summary:
Fixes #23847

How did you verify/test it?
RAn test generic_config_updater.test_eth_interface::test_replace_fec
vikumarks pushed a commit to vikumarks/sonic-mgmt that referenced this pull request Dec 1, 2025
…onic-net#20448)

Summary:
Fixes #23847

How did you verify/test it?
RAn test generic_config_updater.test_eth_interface::test_replace_fec

Signed-off-by: vikumarks <[email protected]>
albertovillarreal-keys pushed a commit to albertovillarreal-keys/sonic-mgmt that referenced this pull request Dec 2, 2025
…onic-net#20448)

Summary:
Fixes #23847

How did you verify/test it?
RAn test generic_config_updater.test_eth_interface::test_replace_fec

Signed-off-by: Alberto Villarreal <[email protected]>
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
…onic-net#20448)

Summary:
Fixes #23847

How did you verify/test it?
RAn test generic_config_updater.test_eth_interface::test_replace_fec

Signed-off-by: opcoder0 <[email protected]>
selldinesh pushed a commit to selldinesh/sonic-mgmt that referenced this pull request Dec 11, 2025
…onic-net#20448)

Summary:
Fixes #23847

How did you verify/test it?
RAn test generic_config_updater.test_eth_interface::test_replace_fec

Signed-off-by: selldinesh <[email protected]>
echuawu pushed a commit to echuawu/sonic-mgmt that referenced this pull request Dec 12, 2025
…onic-net#20448)

Summary:
Fixes #23847

How did you verify/test it?
RAn test generic_config_updater.test_eth_interface::test_replace_fec
saravanan-nexthop pushed a commit to saravanan-nexthop/sonic-mgmt that referenced this pull request Dec 15, 2025
…onic-net#20448)

Summary:
Fixes #23847

How did you verify/test it?
RAn test generic_config_updater.test_eth_interface::test_replace_fec

Signed-off-by: Saravanan <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
…onic-net#20448)

Summary:
Fixes #23847

How did you verify/test it?
RAn test generic_config_updater.test_eth_interface::test_replace_fec

Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
…onic-net#20448)

Summary:
Fixes #23847

How did you verify/test it?
RAn test generic_config_updater.test_eth_interface::test_replace_fec

Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
…onic-net#20448)

Summary:
Fixes #23847

How did you verify/test it?
RAn test generic_config_updater.test_eth_interface::test_replace_fec

Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
…onic-net#20448)

Summary:
Fixes #23847

How did you verify/test it?
RAn test generic_config_updater.test_eth_interface::test_replace_fec
yifan-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Jan 14, 2026
…onic-net#20448)

Summary:
Fixes #23847

How did you verify/test it?
RAn test generic_config_updater.test_eth_interface::test_replace_fec

Signed-off-by: YiFan Wang <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
…onic-net#20448)

Summary:
Fixes #23847

How did you verify/test it?
RAn test generic_config_updater.test_eth_interface::test_replace_fec

Signed-off-by: Guy Shemesh <[email protected]>
lakshmi-nexthop pushed a commit to lakshmi-nexthop/sonic-mgmt that referenced this pull request Jan 28, 2026
…onic-net#20448)

Summary:
Fixes #23847

How did you verify/test it?
RAn test generic_config_updater.test_eth_interface::test_replace_fec

Signed-off-by: Lakshmi Yarramaneni <[email protected]>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Jan 29, 2026
…onic-net#20448)

Summary:
Fixes #23847

How did you verify/test it?
RAn test generic_config_updater.test_eth_interface::test_replace_fec
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
…onic-net#20448)

Summary:
Fixes #23847

How did you verify/test it?
RAn test generic_config_updater.test_eth_interface::test_replace_fec

Signed-off-by: Yael Tzur <[email protected]>
abhishek-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Feb 6, 2026
…onic-net#20448)

Summary:
Fixes #23847

How did you verify/test it?
RAn test generic_config_updater.test_eth_interface::test_replace_fec
rraghav-cisco pushed a commit to rraghav-cisco/sonic-mgmt that referenced this pull request Feb 13, 2026
…onic-net#20448)

Summary:
Fixes #23847

How did you verify/test it?
RAn test generic_config_updater.test_eth_interface::test_replace_fec

Signed-off-by: Raghavendran Ramanathan <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…lly (sonic-net#20448)

#### Why I did it
src/sonic-gnmi
```
* 73069fa - (HEAD -> 202305, origin/202305) Increase dbus timeout for gcu (sonic-net#292) (15 hours ago) [ganglv]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Bug: GCU test_replace_fec fails in multi-asic due to namespace parameter missing from cli call

6 participants