Skip to content

[arp_responder] Let arp_responder send reply when there is no vlan#2346

Merged
lguohan merged 1 commit intosonic-net:masterfrom
shi-su:fix_arp_responder
Oct 15, 2020
Merged

[arp_responder] Let arp_responder send reply when there is no vlan#2346
lguohan merged 1 commit intosonic-net:masterfrom
shi-su:fix_arp_responder

Conversation

@shi-su
Copy link
Copy Markdown
Contributor

@shi-su shi-su commented Oct 14, 2020

Description of PR

Summary: Let arp_responder send reply when there is no vlan
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

What is the motivation for this PR?

The arp_responder should send reply even if there is no vlan. This logic got changed in a recent commit #2236

How did you do it?

Add a vlan_id of None when there is no vlan. As such, the arp_responder could send the proper reply.

How did you verify/test it?

Verified by testing locally.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Copy link
Copy Markdown
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shi-su shi-su requested review from lguohan and qiluo-msft October 14, 2020 19:32
Copy link
Copy Markdown
Contributor

@tahmed-dev tahmed-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work @shi-su

@theasianpianist
Copy link
Copy Markdown
Contributor

@bingwang-ms for visibility

@lguohan lguohan merged commit a125c4a into sonic-net:master Oct 15, 2020
@bingwang-ms
Copy link
Copy Markdown
Collaborator

Thanks for the quick fix @shi-su

kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Update sonic-utilities submodule pointer to include the following:
* [route_check]: Ignore standalone tunnel routes (sonic-net#2325) ([sonic-net#2346](sonic-net/sonic-utilities#2346))
* [VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands ([sonic-net#2333](sonic-net/sonic-utilities#2333))
* Subinterface vrf bind issue fix ([sonic-net#2211](sonic-net/sonic-utilities#2211))
* [decode-syseeprom] Fix setting use_db based on support_eeprom_db ([sonic-net#2270](sonic-net/sonic-utilities#2270))
* Fix vrf UT failed issue ([sonic-net#2309](sonic-net/sonic-utilities#2309))

Signed-off-by: dprital <[email protected]>

Signed-off-by: dprital <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants