Subinterface vrf bind issue fix#2211
Merged
prsunny merged 13 commits intosonic-net:masterfrom Aug 29, 2022
Merged
Conversation
|
This pull request introduces 1 alert and fixes 1 when merging 380339c into a3d1345 - view on LGTM.com new alerts:
fixed alerts:
|
This was referenced Jun 14, 2022
dgsudharsan
requested changes
Jun 15, 2022
Collaborator
dgsudharsan
left a comment
dgsudharsan
left a comment
There was a problem hiding this comment.
Please add UT to cover both the fixes
dgsudharsan
requested changes
Jun 15, 2022
config/main.py
Outdated
| if interface_type == "VLAN_SUB_INTERFACE": | ||
| subintf = config_db.get_entry(interface_type, alias) | ||
| if 'vrf_name' in subintf_entry: | ||
| subintf_entry.pop('vrf') |
Collaborator
There was a problem hiding this comment.
Can you explain the logic here? Why should vrf be popped?
Collaborator
|
Can you please add Unit tests? |
Collaborator
|
@preetham-singh @adyeung Can you please share ETA to add the unit tests? |
Contributor
Author
Sure, I will update tunit tests by 7/15. |
format Update "show subniterface status" to reflect subinterface in user configured long name and short name format.
1. Short Format Subinterface getting deleted after vrf binding . Issue 10802:sonic-net/sonic-buildimage#10802 2. Do not allow short format subinterface to be created without encap vlan configuration. Issue 10878: sonic-net/sonic-buildimage#10878
1. Short Format Subinterface getting deleted after vrf binding . Issue 10802:sonic-net/sonic-buildimage#10802 2. Do not allow short format subinterface to be created without encap vlan configuration. Issue 10878: sonic-net/sonic-buildimage#10878
instead update existing subinterface. Updating unit testcases for subinterfaces.
Collaborator
|
@preetham-singh Can you please check the coverage failure? |
Collaborator
|
Hi @adyeung @preetham-singh Can you please solve the build failure? |
Collaborator
|
Adam will follow up. Thanks |
Contributor
Author
|
Working with SONiC team to resolve code coverage issue for VRF BIND CLI. I will update the PR once code coverage scripts are updated for VRF Bind CLI. |
Contributor
Author
|
This test failure should get resolved once PR #2309 is merged. |
Contributor
Author
|
/azpw run Azure.sonic-utilities |
Collaborator
|
/AzurePipelines run Azure.sonic-utilities |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dgsudharsan
approved these changes
Aug 29, 2022
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Add support to configure routed subinterface in short name and long name format * Update "show subniterface status" to reflect subinterface in user configured long name and short name format.
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Sep 7, 2022
Update sonic-utilities submodule pointer to include the following: * [route_check]: Ignore standalone tunnel routes (sonic-net#2325) ([sonic-net#2346](sonic-net/sonic-utilities#2346)) * [VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands ([sonic-net#2333](sonic-net/sonic-utilities#2333)) * Subinterface vrf bind issue fix ([sonic-net#2211](sonic-net/sonic-utilities#2211)) * [decode-syseeprom] Fix setting use_db based on support_eeprom_db ([sonic-net#2270](sonic-net/sonic-utilities#2270)) * Fix vrf UT failed issue ([sonic-net#2309](sonic-net/sonic-utilities#2309)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
yxieca
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Sep 8, 2022
Update sonic-utilities submodule pointer to include the following: * [route_check]: Ignore standalone tunnel routes (#2325) ([#2346](sonic-net/sonic-utilities#2346)) * [VRF]Adding CLI checks to ensure Vrf is valid in interface bind and static route commands ([#2333](sonic-net/sonic-utilities#2333)) * Subinterface vrf bind issue fix ([#2211](sonic-net/sonic-utilities#2211)) * [decode-syseeprom] Fix setting use_db based on support_eeprom_db ([#2270](sonic-net/sonic-utilities#2270)) * Fix vrf UT failed issue ([#2309](sonic-net/sonic-utilities#2309)) Signed-off-by: dprital <drorp@nvidia.com> Signed-off-by: dprital <drorp@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
This commit addresses below issues:
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)