[bgp] Clear TSA maintenance mode after config reload in test_bgp_update_timer#23350
Open
rustiqly wants to merge 1 commit intosonic-net:masterfrom
Open
[bgp] Clear TSA maintenance mode after config reload in test_bgp_update_timer#23350rustiqly wants to merge 1 commit intosonic-net:masterfrom
rustiqly wants to merge 1 commit intosonic-net:masterfrom
Conversation
…te_timer On platforms with startup_tsa_tsb service enabled in services.conf, config_reload (from setup_interfaces) restarts swss which triggers TSA maintenance mode with a 15-minute TSB timer. Tests running before the timer fires fail because the DUT only advertises its loopback route (PfxSnt: 1). Fix: Check for TSA maintenance mode in common_setup_teardown before yielding to tests, and run TSB to clear it if active. Fixes: sonic-net#23336 Signed-off-by: Rustiqly <[email protected]>
Collaborator
|
/azp run |
Contributor
Author
|
@copilot review |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On platforms with
startup_tsa_tsbservice enabled inservices.conf,config_reload(fromsetup_interfaces) restarts swss which triggers TSA maintenance mode with a 15-minute TSB timer. Tests running before the timer fires fail because the DUT only advertises its loopback route (PfxSnt: 1).Fix
Check for TSA maintenance mode in
common_setup_teardownbefore yielding to tests, and runTSBto clear it if active. UsesTSCto check current maintenance state.Changes
tests/bgp/test_bgp_update_timer.py: Add TSA check/clear incommon_setup_teardownfixture setupFixes: #23336