Skip to content

[generic_config_updater] Add SONiC version precheck for test_buffer_profile_create_remove_rollback #23327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xincunli-sonic merged 2 commits into from
Mar 26, 2026
Merged

[generic_config_updater] Add SONiC version precheck for test_buffer_profile_create_remove_rollback #23327

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3ede9e
generic_config_updater: add version precheck for buffer profile test
xincunli-sonic Mar 26, 2026
5f28a59
generic_config_updater: fix version comparison operator in buffer pro…
xincunli-sonic Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/generic_config_updater/test_incremental_qos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,14 @@ def test_buffer_profile_create_remove_rollback(duthost, ensure_dut_readiness, cl
3. Remove new profile using jsonpatch, check operation success
4. Rollback checkpoint
"""
os_version = duthost.os_version
if "master" not in os_version and "internal" not in os_version:
is_chassis = duthost.get_facts().get("modular_chassis")
min_version = "202405" if is_chassis else "202605"
if os_version.split('.')[0][:6] < min_version:
pytest.skip("Test requires SONiC version >= {} (chassis: {}), current version: {}"
.format(min_version, bool(is_chassis), os_version))

tmpfile = generate_tmpfile(duthost)
profile_name = "pg_lossless_99999_99m_profile"
profile_data = {
Expand Down
Loading