[generic_config_updater] Add SONiC version precheck for test_buffer_profile_create_remove_rollback#23327
Merged
xincunli-sonic merged 2 commits intosonic-net:masterfrom Mar 26, 2026
Conversation
Signed-off-by: Xincun Li <[email protected]>
Collaborator
|
/azp run |
…file test Signed-off-by: Xincun Li <[email protected]>
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ravaliyel
pushed a commit
to ravaliyel/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
…rofile_create_remove_rollback (sonic-net#23327) * generic_config_updater: add version precheck for buffer profile test Signed-off-by: Xincun Li <[email protected]> * generic_config_updater: fix version comparison operator in buffer profile test Signed-off-by: Xincun Li <[email protected]> --------- Signed-off-by: Xincun Li <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Add a SONiC version precheck at the start of
test_buffer_profile_create_remove_rollbackto skip the test on images that do not yet contain the required GCU buffer profile
create/remove support.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
test_buffer_profile_create_remove_rollbackexercises GCU buffer profilecreate/remove/rollback functionality that is only present in SONiC 202605+
(or 202405+ on modular-chassis platforms). Without the precheck, the test
fails spuriously on older images instead of being skipped cleanly.
How did you do it?
Read
duthost.os_versionat the start of the test and compare the first6 characters (YYYYMM) against the minimum required branch string. Modular-
chassis DUTs (detected via
duthost.get_facts().get("modular_chassis"))use a lower minimum of
202405; all other platforms require202605.masterandinternalbuilds always bypass the check.How did you verify/test it?
Manually verified version string parsing logic against both version formats
(
YYYYMM.DDandYYYYMMDD.N) used in the SONiC ecosystem.Any platform specific information?
Modular-chassis DUTs require SONiC >= 202405; non-chassis DUTs require >= 202605.
Supported testbed topology if it's a new test case?
t0
Documentation
N/A
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation