Skip to content

System health fix #23296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mashetta-cisco wants to merge 1 commit into
base: master
Choose a base branch
from
Open

System health fix #23296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions tests/system_health/test_system_health.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@
FAST_INTERVAL = 10
THERMAL_CHECK_INTERVAL = 70
PSU_CHECK_INTERVAL = FAST_INTERVAL + 5
LED_CHECK_INTERVAL = 5
LED_WAIT_TIMEOUT = 60
WAIT_TIMEOUT = 180
STATE_DB = 6

Expand Down Expand Up @@ -161,11 +163,26 @@ def test_service_checker_with_process_exit(duthosts, enum_rand_one_per_hwsku_hos

assert result is True, '{} is not recorded'.format(
critical_process)
summary_result = wait_until(
WAIT_TIMEOUT, 10, 2, check_system_health_info, duthost, 'summary', SUMMARY_NOT_OK)
summary = redis_get_field_value(
duthost, STATE_DB, HEALTH_TABLE_NAME, 'summary')
assert summary == SUMMARY_NOT_OK, 'Expect summary {}, got {}'.format(
assert summary_result is True, 'Expect summary {}, got {}'.format(
SUMMARY_NOT_OK, summary)
check_system_health_led_info(duthost)
led_result = wait_until(
LED_WAIT_TIMEOUT, LED_CHECK_INTERVAL, 0,
check_system_health_led_info, duthost
)
if not led_result:
system_health_summary = duthost.shell(
'show system-health summary'
)['stdout']
pytest.fail(
'System status LED did not converge to expected fault '
'color in {} seconds. Latest summary:\n{}'.format(
LED_WAIT_TIMEOUT, system_health_summary
)
)
break


Expand Down