Open
Conversation
Collaborator
|
/azp run |
|
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
The killed process fault can appear before the summary field or the LED state can update. This can result in the test failing with the result;
This diff adds an LED time constraint to wait for SYSTEM_HEALTH_INFO.summary to become
Not OK, instead of an immediate read. The LED state is then polled for 60s, every 5 seconds.If the LED state hasn't converged after the poll, the test fails
Type of change
Back port request
Approach
What is the motivation for this PR?
test_service_checker_with_process_exitwould intermittently fail when the process failure is detected before the CLI and the LED had converged.How did you do it?
Changed the test to wait for
SYSTEM_HEALTH_INFO.summaryto becomeNot OKand then poll LED state.How did you verify/test it?
Manually ran the tests.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation