Skip to content

System health fix#23296

Open
mashetta-cisco wants to merge 1 commit intosonic-net:masterfrom
mashetta-cisco:mashetta/system-health
Open

System health fix#23296
mashetta-cisco wants to merge 1 commit intosonic-net:masterfrom
mashetta-cisco:mashetta/system-health

Conversation

@mashetta-cisco
Copy link

Description of PR

Summary:
The killed process fault can appear before the summary field or the LED state can update. This can result in the test failing with the result;

System status LED is not yellow, amber, or red, but it is green

This diff adds an LED time constraint to wait for SYSTEM_HEALTH_INFO.summary to become Not OK, instead of an immediate read. The LED state is then polled for 60s, every 5 seconds.

If the LED state hasn't converged after the poll, the test fails

Type of change

  • [ x] Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • [ x] Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • [ x] 202511

Approach

What is the motivation for this PR?

test_service_checker_with_process_exit would intermittently fail when the process failure is detected before the CLI and the LED had converged.

How did you do it?

Changed the test to wait for SYSTEM_HEALTH_INFO.summary to become Not OK and then poll LED state.

How did you verify/test it?

Manually ran the tests.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

@linux-foundation-easycla
Copy link

CLA Not Signed

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mashetta-cisco mashetta-cisco marked this pull request as ready for review March 25, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants