[action] [PR:23257] Add ASIC-based skip condition for generic_config_updater/test_srv6#23284
Open
mssonicbld wants to merge 1 commit intosonic-net:202511from
Open
[action] [PR:23257] Add ASIC-based skip condition for generic_config_updater/test_srv6#23284mssonicbld wants to merge 1 commit intosonic-net:202511from
mssonicbld wants to merge 1 commit intosonic-net:202511from
Conversation
…v6 (sonic-net#23257) SRv6 config updater tests fail on platforms that do not support SRv6. The test configures SRV6_MY_LOCATORS and SRV6_MY_SIDS in CONFIG_DB, which causes SAI errors on unsupported ASICs. The loganalyzer in teardown catches these errors and fails the test. Affected ASICs: Broadcom TH/TH2/TD3, Mellanox SPC1/SPC2/SPC3. SRv6-capable ASICs: Broadcom TH5+, Mellanox SPC4+, Cisco Q200/Q201L. Kusto data from 202511 .17 image shows 122/137 failures, all on non-SRv6 ASICs. The existing skip condition only covers topology (t0-isolated-d96u32s2) but not ASIC type. This change adds ASIC-based skip conditions matching the pattern used in srv6/test_srv6_dataplane.py (PR sonic-net#21713). Signed-off-by: Storm Liang <stormliang@microsoft.com> Signed-off-by: mssonicbld <sonicbld@microsoft.com>
mssonicbld
requested review from
BYGX-wcr and
yutongzhang-microsoft
as code owners
12 tasks
Collaborator
Author
|
Original PR: #23257 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Add ASIC-based skip conditions for
generic_config_updater/test_srv6tests to prevent failures on platforms that do not support SRv6. The existing skip condition only covers topology (t0-isolated-d96u32s2), but SRv6 config updater tests also fail on older ASICs (Broadcom TH/TH2/TD3, Mellanox SPC1-3) because applying SRv6 CONFIG_DB entries triggers SAI errors caught by the loganalyzer during teardown.Type of change
Back port request
Approach
What is the motivation for this PR?
Kusto data from 202511 .17 image (
20251110.17) shows 122 out of 137 test runs ofgeneric_config_updater/test_srv6failed. All failures occurred on non-SRv6-capable ASICs:The regression grew across image versions: .15 had 0 failures, .16 had 4 failures, .17 had 122 failures due to broader platform test coverage.
PR #21713 adds similar ASIC-based skip conditions for
srv6/test_srv6_dataplane.pybut missesgeneric_config_updater/test_srv6. PR #23226 adds loganalyzer ignore for SRv6 SAI errors but doesn't address the root cause of running SRv6 config tests on unsupported platforms.How did you do it?
Updated
tests/common/plugins/conditional_mark/tests_mark_conditions.yamlto add ASIC-based skip conditions forgeneric_config_updater/test_srv6:t0-isolated-d96u32s2The conditions use
ORlogic (skip if ANY condition matches) and follow the same pattern assrv6/test_srv6_dataplane.pyskip conditions.How did you verify/test it?
Any platform specific information?
Platforms affected (will now be skipped):
Platforms NOT affected (will continue to run):
Supported testbed topology if it's a new test case?
N/A - bug fix for existing tests
Documentation
N/A