Skip to content

Add ASIC-based skip condition for generic_config_updater/test_srv6#23257

Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom
StormLiangMS:fix-srv6-config-updater-skip-condition
Mar 25, 2026
Merged

Add ASIC-based skip condition for generic_config_updater/test_srv6#23257
StormLiangMS merged 1 commit intosonic-net:masterfrom
StormLiangMS:fix-srv6-config-updater-skip-condition

Conversation

@StormLiangMS
Copy link
Collaborator

@StormLiangMS StormLiangMS commented Mar 24, 2026

Description of PR

Summary:
Add ASIC-based skip conditions for generic_config_updater/test_srv6 tests to prevent failures on platforms that do not support SRv6. The existing skip condition only covers topology (t0-isolated-d96u32s2), but SRv6 config updater tests also fail on older ASICs (Broadcom TH/TH2/TD3, Mellanox SPC1-3) because applying SRv6 CONFIG_DB entries triggers SAI errors caught by the loganalyzer during teardown.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

Approach

What is the motivation for this PR?

Kusto data from 202511 .17 image (20251110.17) shows 122 out of 137 test runs of generic_config_updater/test_srv6 failed. All failures occurred on non-SRv6-capable ASICs:

The regression grew across image versions: .15 had 0 failures, .16 had 4 failures, .17 had 122 failures due to broader platform test coverage.

PR #21713 adds similar ASIC-based skip conditions for srv6/test_srv6_dataplane.py but misses generic_config_updater/test_srv6. PR #23226 adds loganalyzer ignore for SRv6 SAI errors but doesn't address the root cause of running SRv6 config tests on unsupported platforms.

How did you do it?

Updated tests/common/plugins/conditional_mark/tests_mark_conditions.yaml to add ASIC-based skip conditions for generic_config_updater/test_srv6:

  • Skip for unsupported ASIC types (not mellanox/broadcom/cisco/vs)
  • Skip for Mellanox SPC1/SPC2/SPC3 (only SPC4+ supports SRv6)
  • Skip for Broadcom non-TH5 (only TH5+ supports SRv6)
  • Keep existing topology skip for t0-isolated-d96u32s2

The conditions use OR logic (skip if ANY condition matches) and follow the same pattern as srv6/test_srv6_dataplane.py skip conditions.

How did you verify/test it?

  • Cross-referenced Kusto failure data across .15, .16, and .17 images
  • Verified all 122 failures occur on ASICs that match the new skip conditions
  • Confirmed passing platforms (TH5, SPC4+, Cisco Q200/Q201L) are NOT matched by skip conditions
  • YAML syntax validated

Any platform specific information?

Platforms affected (will now be skipped):

  • Broadcom TH, TH2, TD3 (all models)
  • Mellanox SPC1, SPC2, SPC3 (all models)

Platforms NOT affected (will continue to run):

  • Broadcom TH5+
  • Mellanox SPC4+
  • Cisco Q200, Q201L
  • VS (virtual switch)

Supported testbed topology if it's a new test case?

N/A - bug fix for existing tests

Documentation

N/A

SRv6 config updater tests fail on platforms that do not support SRv6.
The test configures SRV6_MY_LOCATORS and SRV6_MY_SIDS in CONFIG_DB,
which causes SAI errors on unsupported ASICs. The loganalyzer in
teardown catches these errors and fails the test.

Affected ASICs: Broadcom TH/TH2/TD3, Mellanox SPC1/SPC2/SPC3.
SRv6-capable ASICs: Broadcom TH5+, Mellanox SPC4+, Cisco Q200/Q201L.

Kusto data from 202511 .17 image shows 122/137 failures, all on
non-SRv6 ASICs. The existing skip condition only covers topology
(t0-isolated-d96u32s2) but not ASIC type.

This change adds ASIC-based skip conditions matching the pattern
used in srv6/test_srv6_dataplane.py (PR sonic-net#21713).

Signed-off-by: Storm Liang <stormliang@microsoft.com>
@mssonicbld
Copy link
Collaborator

/azp run

@StormLiangMS StormLiangMS added the Request for 202511 branch Request to backport a change to 202511 branch label Mar 24, 2026
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@BYGX-wcr BYGX-wcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markx-arista
Copy link
Contributor

@StormLiangMS Can you exclude th6 and q3d in Broadcom's skip condition too? Thanks.

@StormLiangMS StormLiangMS merged commit 12c23cf into sonic-net:master Mar 25, 2026
19 checks passed
@StormLiangMS
Copy link
Collaborator Author

@StormLiangMS Can you exclude th6 and q3d in Broadcom's skip condition too? Thanks.
@markx-arista what is the q3d?

mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Mar 25, 2026
…v6 (sonic-net#23257)

SRv6 config updater tests fail on platforms that do not support SRv6.
The test configures SRV6_MY_LOCATORS and SRV6_MY_SIDS in CONFIG_DB,
which causes SAI errors on unsupported ASICs. The loganalyzer in
teardown catches these errors and fails the test.

Affected ASICs: Broadcom TH/TH2/TD3, Mellanox SPC1/SPC2/SPC3.
SRv6-capable ASICs: Broadcom TH5+, Mellanox SPC4+, Cisco Q200/Q201L.

Kusto data from 202511 .17 image shows 122/137 failures, all on
non-SRv6 ASICs. The existing skip condition only covers topology
(t0-isolated-d96u32s2) but not ASIC type.

This change adds ASIC-based skip conditions matching the pattern
used in srv6/test_srv6_dataplane.py (PR sonic-net#21713).

Signed-off-by: Storm Liang <stormliang@microsoft.com>
Signed-off-by: mssonicbld <sonicbld@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202511: #23284

@markx-arista
Copy link
Contributor

markx-arista commented Mar 25, 2026

@StormLiangMS Can you exclude th6 and q3d in Broadcom's skip condition too? Thanks.
@markx-arista what is the q3d?

It's a DNX ASIC Qumran3D, used by x86_64-arista_7280r4[k]_32qf_32df
https://github.com/sonic-net/sonic-buildimage/blob/master/device/arista/x86_64-arista_7280r4_32qf_32df/Arista-7280R4-32QF-32DF-64O/sai.profile
There is a skip condition for it already:
https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/plugins/conditional_mark/tests_mark_conditions.yaml#L3647

@StormLiangMS
Copy link
Collaborator Author

@StormLiangMS Can you exclude th6 and q3d in Broadcom's skip condition too? Thanks.
@markx-arista what is the q3d?

It's a DNX ASIC Qumran3D, used by x86_64-arista_7280r4[k]_32qf_32df https://github.com/sonic-net/sonic-buildimage/blob/master/device/arista/x86_64-arista_7280r4_32qf_32df/Arista-7280R4-32QF-32DF-64O/sai.profile There is a skip condition for it already: https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/plugins/conditional_mark/tests_mark_conditions.yaml#L3647

hi @markx-arista I merged this to stop bleeding, could you file a PR for this unskip?

@markx-arista
Copy link
Contributor

@StormLiangMS Can you exclude th6 and q3d in Broadcom's skip condition too? Thanks.
@markx-arista what is the q3d?

It's a DNX ASIC Qumran3D, used by x86_64-arista_7280r4[k]_32qf_32df https://github.com/sonic-net/sonic-buildimage/blob/master/device/arista/x86_64-arista_7280r4_32qf_32df/Arista-7280R4-32QF-32DF-64O/sai.profile There is a skip condition for it already: https://github.com/sonic-net/sonic-mgmt/blob/master/tests/common/plugins/conditional_mark/tests_mark_conditions.yaml#L3647

hi @markx-arista I merged this to stop bleeding, could you file a PR for this unskip?

Done: #23314

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants