Skip to content

Fix more tests on VOQ systems without chassis_app_db#23217

Merged
yxieca merged 1 commit intosonic-net:masterfrom
arista-nwolfe:master-no-chassisdb-test-fixes
Mar 27, 2026
Merged

Fix more tests on VOQ systems without chassis_app_db#23217
yxieca merged 1 commit intosonic-net:masterfrom
arista-nwolfe:master-no-chassisdb-test-fixes

Conversation

@arista-nwolfe
Copy link
Copy Markdown
Contributor

Should skip/fix:
bgp/test_traffic_shift_lc.py
bgp/test_startup_tsa_tsb_service.py
voq/test_voq_intfs.py

Failures seen:
bgp/test_traffic_shift_lc.py:

bgp/bgp_helpers.py:989: in run_tsb_on_linecard_and_verify
    if verify_dut_configdb_tsa_value(lc) is not False or get_tsa_chassisdb_config(lc) != 'false' or \
                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        lc         = <MultiAsicSonicHost ctn101>
bgp/bgp_helpers.py:946: in get_tsa_chassisdb_config
    tsa_conf = duthost.shell('sonic-db-cli CHASSIS_APP_DB HGET \'BGP_DEVICE_GLOBAL|STATE\' tsa_enabled')['stdout']
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        duthost    = <MultiAsicSonicHost ctn101>

bgp/test_startup_tsa_tsb_service.py:

bgp/bgp_helpers.py:989: in run_tsb_on_linecard_and_verify
    if verify_dut_configdb_tsa_value(lc) is not False or get_tsa_chassisdb_config(lc) != 'false' or \
                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        lc         = <MultiAsicSonicHost ctn101>
bgp/bgp_helpers.py:946: in get_tsa_chassisdb_config
    tsa_conf = duthost.shell('sonic-db-cli CHASSIS_APP_DB HGET \'BGP_DEVICE_GLOBAL|STATE\' tsa_enabled')['stdout']
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        duthost    = <MultiAsicSonicHost ctn101>

voq/test_voq_intfs.py:

voq/test_voq_init.py:219: in check_voq_interfaces
    voqdb = VoqDbCli(per_host)
            ^^^^^^^^^^^^^^^^^^
        <trim>
common/helpers/sonic_db.py:503: in __init__
    output = host.command("grep chassis_db_address /etc/sonic/chassisdb.conf")
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        __class__  = &lt;class 'tests.common.helpers.sonic_db.VoqDbCli'&gt;
        host       = &lt;MultiAsicSonicHost ctn101&gt;
        self       = &lt;tests.common.helpers.sonic_db.VoqDbCli object at 0x7f96ea1591f0&gt;

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

Should skip/fix:
bgp/test_traffic_shift_lc.py
bgp/test_startup_tsa_tsb_service.py
voq/test_voq_intfs.py

Signed-off-by: Nathan Wolfe <[email protected]>
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — clean fix guarding get_tsa_chassisdb_config() behind is_chassis check for non-chassis VOQ systems. CI all green.

@yxieca
Copy link
Copy Markdown
Collaborator

yxieca commented Mar 27, 2026

@arista-nwolfe going forward, please use the PR template defined in the repo. Thanks.

@yxieca yxieca merged commit d6848f9 into sonic-net:master Mar 27, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants