[202511] add authtype for consoleserver (#22679)#22974
Merged
vmittal-msft merged 1 commit intosonic-net:202511from Mar 17, 2026
Merged
[202511] add authtype for consoleserver (#22679)#22974vmittal-msft merged 1 commit intosonic-net:202511from
vmittal-msft merged 1 commit intosonic-net:202511from
Conversation
Summary: support specifying authentication credential choice for console server (e.g. TACACS or AAD), With the following device: Hostname,ManagementIp,HwSku,Type,Protocol,Os,AuthType console-1,192.168.10.1/23,Cisco,ConsoleServer,ssh,sonic,, console-2,192.168.10.2/23,Cisco,ConsoleServer,ssh,sonic,,tacacs console-1 will use the default credentials in secrets.yaml "console_login". console-2 will use more specific credentials in secrets.yaml "console_login_options['tacacs']" What is the motivation for this PR? user can use different credential for console server. How did you do it? introduced new console_type, CONSOLE_SSH_TACACS How did you verify/test it? Verified locally. Signed-off-by: Dashuai Zhang <dashuaizhang@microsoft.com>
sdszhang
requested review from
Xichen96,
cyw233,
lizhijianrd,
lolyu,
r12f,
wangxin,
xwjiang-ms and
yutongzhang-microsoft
as code owners
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
approved these changes
Mar 14, 2026
Contributor
|
re-trigger the pipeline for pr test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Cherry-pick of #22679 to 202511 branch.
Summary:
support specifying authentication credential choice for console server (e.g. TACACS or AAD),
With the following device:
console-1 will use the default credentials in secrets.yaml "console_login".
console-2 will use more specific credentials in secrets.yaml "console_login_options['tacacs']"
Type of change
Approach
What is the motivation for this PR?
user can use different credential for console server.
How did you do it?
introduced new console_type, CONSOLE_SSH_TACACS
How did you verify/test it?
Verified locally.
Conflict resolution
Resolved conflict in
tests/common/helpers/dut_utils.py- kept 202511 branch'sconsole_menu_typehandling and addedupdate_console_credscall.