Enable link training support in sonic-mgmt#22870
Closed
sdszhang wants to merge 5 commits intosonic-net:masterfrom
Closed
Enable link training support in sonic-mgmt#22870sdszhang wants to merge 5 commits intosonic-net:masterfrom
sdszhang wants to merge 5 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdszhang
added
Request for msft-202503 Branch
Request for 202511 branch
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables link-training support in sonic-mgmt by propagating link-training metadata from the connection graph into generated minigraph/link metadata and fanout config templates.
Changes:
- Add
LinkTrainingparsing from CSV link facts into graph facts (device_conn/graph_facts["links"]). - Emit
LinkTrainingdevice properties in the minigraph link metadata template. - Emit link-training configuration for SONiC fanout deployment (202405 template).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| ansible/templates/minigraph_link_meta.j2 | Adds LinkTraining property emission into link metadata rendering. |
| ansible/roles/fanout/templates/sonic_deploy_202405.j2 | Adds link-training field to generated fanout PORT config. |
| ansible/module_utils/graph_utils.py | Parses LinkTraining from CSV links into graph facts. |
prgeor
reviewed
Mar 11, 2026
Signed-off-by: Dashuai Zhang <dashuaizhang@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Dashuai Zhang <dashuaizhang@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Dashuai Zhang <dashuaizhang@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
12 tasks
Collaborator
|
This PR LGTM. But it has dependency on sonic-net/sonic-buildimage#26129 |
yxieca
approved these changes
Mar 18, 2026
Collaborator
yxieca
left a comment
yxieca
left a comment
There was a problem hiding this comment.
AI agent on behalf of Ying. Reviewed; no issues found.
Contributor
Author
|
closing this PR as minigraph is not suppose to be changed anymore. New method is using golden_config_db to generate link_training config. #23107 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Enable link-training support in sonic-mgmt
Type of change
Back port request
Approach
What is the motivation for this PR?
Enable link-training support in sonic-mgmt
How did you do it?
Add link training into minigraph template
How did you verify/test it?
local testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation