Skip to content

add linkTraining support in minigraph parsing#26129

Closed
sdszhang wants to merge 3 commits intosonic-net:masterfrom
sdszhang:link_training
Closed

add linkTraining support in minigraph parsing#26129
sdszhang wants to merge 3 commits intosonic-net:masterfrom
sdszhang:link_training

Conversation

@sdszhang
Copy link
Contributor

Why I did it

Add LinkTraining support in minigraph processing.

Work item tracking
  • Microsoft ADO 36809108:

How I did it

parse 'LinkTraining' and convert to config_db.json.

How to verify it

verified locally.

Which release branch to backport (provide reason below if selected)

  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Dashuai Zhang <[email protected]>
Copilot AI review requested due to automatic review settings March 11, 2026 10:17
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support in sonic-config-engine minigraph parsing to carry LinkTraining metadata from the minigraph into the generated PORT configuration, overriding any port_config.ini setting when present.

Changes:

  • Parse LinkTraining from minigraph LinkMetadata properties into linkmetas
  • Override per-port link_training in the generated PORT table based on minigraph values (similar to existing AutoNegotiation behavior)

@sdszhang sdszhang changed the title add linkTraining support in minigraph add linkTraining support in minigraph parsing Mar 11, 2026
prgeor
prgeor previously approved these changes Mar 11, 2026
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Dashuai Zhang <[email protected]>
Copilot AI review requested due to automatic review settings March 13, 2026 05:13
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


You can also share your feedback on Copilot code review. Take the survey.

Signed-off-by: Dashuai Zhang <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms
Copy link
Contributor

minigraph.py is protected now. Is it possible to handle the new attribute in golden_config_db.json?

@sdszhang
Copy link
Contributor Author

closing this PR as minigraph is not suppose to be changed anymore. New method is using golden_config_db to generate link_training config. sonic-net/sonic-mgmt#23107

@sdszhang sdszhang closed this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants