Skip to content

[Otel] Enable OTEL feature when OTEL image exists#22341

Merged
StormLiangMS merged 6 commits intosonic-net:masterfrom
Janetxxx:dev/jc/enable-otel
Mar 12, 2026
Merged

[Otel] Enable OTEL feature when OTEL image exists#22341
StormLiangMS merged 6 commits intosonic-net:masterfrom
Janetxxx:dev/jc/enable-otel

Conversation

@Janetxxx
Copy link
Contributor

@Janetxxx Janetxxx commented Feb 11, 2026

Description of PR

Summary: Enable OTEL feature when OTEL image exists
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

Approach

What is the motivation for this PR?

Enable OTEL feature when OTEL image exists

How did you do it?

Add a function to check if otel docker image exists, if yes, enable otel feature.

How did you verify/test it?

Verified it in internal setup.

Any platform specific information?

Nvidia SN5640

Supported testbed topology if it's a new test case?

to-isolated-d32u32s2

Documentation

Signed-off-by: Janet Cui <janet970527@gmail.com>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Janetxxx Janetxxx added the Request for 202511 branch Request to backport a change to 202511 branch label Feb 11, 2026
Signed-off-by: Janet Cui <janet970527@gmail.com>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Pterosaur
Copy link
Contributor

Please change the PR title

Copy link
Collaborator

@r12f r12f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR title. 20241212.49 is not visible in community.

This should be checking if OTEL feature exist or not.

@r12f
Copy link
Collaborator

r12f commented Feb 13, 2026

CI is also failing. need to fix.

@Janetxxx Janetxxx changed the title [Otel] Enable otel for image version greater than 20241212.49 [Otel] Enable OTEL feature when OTEL image exists Feb 14, 2026
Signed-off-by: Janet Cui <janet970527@gmail.com>
@github-actions github-actions bot requested a review from r12f February 16, 2026 06:29
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Janet Cui <janet970527@gmail.com>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Janet Cui <janet970527@gmail.com>
@github-actions github-actions bot requested a review from r12f March 5, 2026 11:33
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Janet Cui <janet970527@gmail.com>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Janetxxx
Copy link
Contributor Author

Janetxxx commented Mar 6, 2026

PR checker container_hardening/test_container_hardening.py will be passed once sonic-net/sonic-buildimage#25930 gets merged

@StormLiangMS StormLiangMS merged commit 02b80dc into sonic-net:master Mar 12, 2026
21 of 22 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Mar 16, 2026
What is the motivation for this PR?
Enable OTEL feature when OTEL image exists

How did you do it?
Add a function to check if otel docker image exists, if yes, enable otel feature.

How did you verify/test it?
Verified it in internal setup.

Any platform specific information?
Nvidia SN5640

Supported testbed topology if it's a new test case?
to-isolated-d32u32s2
Signed-off-by: Janet Cui <janet970527@gmail.com>
Signed-off-by: mssonicbld <sonicbld@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202511: #23006

selldinesh pushed a commit to selldinesh/sonic-mgmt that referenced this pull request Mar 16, 2026
What is the motivation for this PR?
Enable OTEL feature when OTEL image exists

How did you do it?
Add a function to check if otel docker image exists, if yes, enable otel feature.

How did you verify/test it?
Verified it in internal setup.

Any platform specific information?
Nvidia SN5640

Supported testbed topology if it's a new test case?
to-isolated-d32u32s2
Signed-off-by: Janet Cui <janet970527@gmail.com>
Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
abhishek-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Mar 17, 2026
What is the motivation for this PR?
Enable OTEL feature when OTEL image exists

How did you do it?
Add a function to check if otel docker image exists, if yes, enable otel feature.

How did you verify/test it?
Verified it in internal setup.

Any platform specific information?
Nvidia SN5640

Supported testbed topology if it's a new test case?
to-isolated-d32u32s2
Signed-off-by: Janet Cui <janet970527@gmail.com>
Signed-off-by: Abhishek <abhishek@nexthop.ai>
vmittal-msft pushed a commit that referenced this pull request Mar 19, 2026
What is the motivation for this PR?
Enable OTEL feature when OTEL image exists

How did you do it?
Add a function to check if otel docker image exists, if yes, enable otel feature.

How did you verify/test it?
Verified it in internal setup.

Any platform specific information?
Nvidia SN5640

Supported testbed topology if it's a new test case?
to-isolated-d32u32s2

Signed-off-by: Janet Cui <janet970527@gmail.com>
Signed-off-by: mssonicbld <sonicbld@microsoft.com>
Co-authored-by: Janet Cui <janet970527@gmail.com>
vrajeshe pushed a commit to vrajeshe/sonic-mgmt that referenced this pull request Mar 23, 2026
What is the motivation for this PR?
Enable OTEL feature when OTEL image exists

How did you do it?
Add a function to check if otel docker image exists, if yes, enable otel feature.

How did you verify/test it?
Verified it in internal setup.

Any platform specific information?
Nvidia SN5640

Supported testbed topology if it's a new test case?
to-isolated-d32u32s2
Signed-off-by: Janet Cui <janet970527@gmail.com>
Signed-off-by: Venkata Gouri Rajesh Etla <vrajeshe@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants