[Otel] Fix argument mismatch in overwrite_feature_golden_config_db_singleasic call#1070
Merged
Janetxxx merged 1 commit intoAzure:202412from Mar 14, 2026
Merged
Conversation
…ngleasic call PR Azure#1067 cherry-picked the otel feature enablement from upstream PR #22341, but the upstream overwrite_feature_golden_config_db_singleasic() accepts optional auto_restart and state parameters, while the 202412 branch version only accepts (config, feature_key) and hardcodes both as 'enabled'. This causes a TypeError at runtime: TypeError: overwrite_feature_golden_config_db_singleasic() takes 3 positional arguments but 5 were given Fix by removing the extra arguments since the 202412 branch already hardcodes the desired 'enabled' values. Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Dashuai Zhang <dashuaizhang@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this PR?
PR #1067 cherry-picked the otel feature enablement from upstream PR sonic-net/sonic-mgmt#22341, but introduced a runtime bug.
What is the issue?
The upstream
overwrite_feature_golden_config_db_singleasic()accepts optionalauto_restartandstateparameters:But the 202412 branch version only accepts
(config, feature_key)and hardcodes both as"enabled":The cherry-picked call passes 4 arguments:
This causes a TypeError at runtime:
How did you fix it?
Removed the extra
"enabled", "enabled"arguments since the 202412 branch already hardcodes those values.How did you verify/test it?
Verified the method signature matches the call site. Python syntax check passes.