Ansible run roles even when: is false. Fix the issue with running roles#223
Merged
lguohan merged 2 commits intosonic-net:masterfrom Jul 27, 2017
Merged
Ansible run roles even when: is false. Fix the issue with running roles#223lguohan merged 2 commits intosonic-net:masterfrom
lguohan merged 2 commits intosonic-net:masterfrom
Conversation
pavel-shirshov
approved these changes
Jul 26, 2017
ansible/testbed_add_vm_topology.yml
Outdated
| set_fact: properties_list=configuration[hostname]['properties'] | ||
| when: configuration and configuration[hostname] and configuration[hostname]['properties'] is defined | ||
|
|
||
| - debug: msg="{{ inventory_hostname }}" |
Contributor
There was a problem hiding this comment.
Do we need this debug here?
Probably it's better to use it as
debug: var=inventory_hostname
?
lguohan
added a commit
that referenced
this pull request
Aug 3, 2017
…es (#223) * Ansible run roles even when: is false. Fix the issue with running roles
nhe-NV
pushed a commit
to nhe-NV/sonic-mgmt
that referenced
this pull request
May 12, 2025
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes sanity check for isolated-v6 which is ipv6 only topology ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 ### Approach #### What is the motivation for this PR? support ipv6 only topology in sanity check. #### How did you do it? - check ip_interface for IPv4 only. - check bgp router id same as loopback0 for IPv4 only. - check v4_default_route only when there are IPv4 BGP neighbors. #### How did you verify/test it? Test passed on local testbed. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
sonic-net#17731) #### Why I did it src/linkmgrd ``` * 2f5971f - (HEAD -> 202305, origin/202305) [warmboot] use config_db connector to update mux mode config instead of CLI (sonic-net#223) (4 hours ago) [Jing Zhang] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.