[action] [PR:17694] disable checking queue counter in pfc_pause_test#17731
Merged
mssonicbld merged 1 commit intosonic-net:202405from Mar 28, 2025
Merged
[action] [PR:17694] disable checking queue counter in pfc_pause_test#17731mssonicbld merged 1 commit intosonic-net:202405from
mssonicbld merged 1 commit intosonic-net:202405from
Conversation
* remove delay for reading counter in pfc_pause_test Signed-off-by: Xu Chen <xuchen3@microsoft.com>
11 tasks
Collaborator
Author
|
Original PR: #17694 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
test_pfc_pause_extra_lossless_standby case failed, as below:
How did you do it?
RCA:
after 10 sec delay in queue counter reading, pfc frames sending might actually had already stopped.
so bounce back packet might still send out, and queue counter increased accordingly.
and then caused flaky test faiure.
How did you verify/test it?
temporarily disable the assert queue counter here until find a better solution, such as reading counter using sai thrift API
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation