Skip to content

[action] [PR:17694] disable checking queue counter in pfc_pause_test#17731

Merged
mssonicbld merged 1 commit intosonic-net:202405from
mssonicbld:cherry/202405/17694
Mar 28, 2025
Merged

[action] [PR:17694] disable checking queue counter in pfc_pause_test#17731
mssonicbld merged 1 commit intosonic-net:202405from
mssonicbld:cherry/202405/17694

Conversation

@mssonicbld
Copy link
Copy Markdown
Collaborator

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
  • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

test_pfc_pause_extra_lossless_standby case failed, as below:

Failed: The queue 2 for port Ethernet60 counter increased unexpectedly:

Failed: The queue 6 for port Ethernet60 counter increased unexpectedly:

Failed: The queue 2 for port Ethernet172 counter increased unexpectedly: Received packet that we expected not to receive on device 0, port 71.
========== RECEIVED ==========
0000 42 6E C4 BB E2 A1 A4 3F 68 FA 7C 0C 08 00 45 09 Bn.....?h.|...E.
0010 00 6A 05 6A 00 00 FF 04 A1 DA 0A 01 00 21 0A 01 .j.j.........!..
0020 00 20 45 0D 00 56 00 01 00 00 3F 06 B8 E8 01 01 . E..V....?.....
0030 01 01 C0 A8 00 02 04 D2 00 50 00 00 00 00 00 00 .........P......
0040 00 00 50 02 20 00 94 88 00 00 74 65 73 74 73 2E ..P. .....tests.
0050 71 6F 73 2E 74 65 73 74 5F 74 75 6E 6E 65 6C 5F qos.test_tunnel_
0060 71 6F 73 5F 72 65 6D 61 70 20 74 65 73 74 73 2E qos_remap tests.
0070 71 6F 73 2E 74 65 73 74 qos.test
==============================

How did you do it?

RCA:
after 10 sec delay in queue counter reading, pfc frames sending might actually had already stopped.
so bounce back packet might still send out, and queue counter increased accordingly.
and then caused flaky test faiure.

How did you verify/test it?

temporarily disable the assert queue counter here until find a better solution, such as reading counter using sai thrift API

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

* remove delay for reading counter in pfc_pause_test

Signed-off-by: Xu Chen <xuchen3@microsoft.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator Author

Original PR: #17694

@mssonicbld
Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit 9bf5524 into sonic-net:202405 Mar 28, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants