Add cavium platform port configuration

[NStetskovych-zz]

Port mapping for cavium sonic deployment

[lguohan]

modprobe should be integrated into xp80PcieEndpoint deb packet, pre-install script

[NStetskovych-zz]

done.

[lguohan]

depmod -a should be integrated into xp80PcieEndpoint, post-install script.

[NStetskovych-zz]

yes, will change in next commit

[qiluo-msft]

Who need this? Can it handle the path inside a container? Or just use original path?
#Closed

[NStetskovych-zz]

We use sonic_portsku in inventory to setup box in coresponding mode( i.e 40G):
switch-1 ansible_host=10.7.2.84 sonic_version=v2 sonic_portsku=32x40 sonic_hwsku=AS7512, and have corresponding port maping files.
In SONic application just port_config.ini is used, so for this purpose symlink is created.

[qiluo-msft]

I don't see sonic_portsku in inventory. Is it true that we can get the unique 'sonic_portsku' from 'sonic_hwsku'? Is it possible to handle all the complexity inside the container?
#Closed

[NStetskovych-zz]

I did not push changes to inventory yet. Afraid to broke deployment without -l (till all our changes will be integrated). Will test inside container.

[NStetskovych-zz]

Change orchagent ssw volumes to rw again ( no need 'w' sorry for inconvenience as it was done some time ago). Acconrding to @lguohan comment that it's better to create the symbol link outside the container. It`s really better to create symlink in "source" file system for consistency.

[NStetskovych-zz]

I just saw that in main.yaml we have the following task - that already copy the folder we needed

- name: Copy SSW files.
  copy: directory_mode=0755
        src=ssw/{{ sonic_hwsku }}
        dest=/etc/ssw

So we just create one more symlink under our platform folder , and do not even change orchagent volumes.
#Closed

[qiluo-msft]

Let me clarify my points. I guess your requirements are:

1. In the orchagent container, you will need a file "port_config.ini", and you will never read the files "port_config_*.ini" directly
2. The content of the file "port_config.ini" is determined during deployment, and never changed on the switch box.
   Since the requirement is different from all other vendors. Suggest not to follow the "Copy SSW files".

To keep it very clean and consistent, suggest you not put source files in ansible/roles/sonicv2/files/ssw/. Instead, create a 'copy' task in sonic-cavm.yml, and the src parameter will be determined based on the port sku variable. So you don't need to copy many files to switch, don't need to create a symlink at all. Below is a sample (please test before using:))

- name: Copy the port config file based on port sku
  copy:
    src: /etc/ssw_extra/{{ sonic_hwsku }}/port_config_{{ sonic_portsku }}.ini
    dest: /etc/ssw/{{ sonic_hwsku }}/port_config.ini

---

In reply to: 83538433 [](ancestors = 83538433)

[qiluo-msft]

ro is enough. #Closed
#Closed

[NStetskovych-zz]

rw is used to create symlink mentioned above.

[lguohan]

it's better to create the symbol link outside the container and map to container using ro.

[qiluo-msft]

Who need this? #Closed
#Closed

[NStetskovych-zz]

syncd use this - /etc/ssw/{{sonic_hwsku}}/profile.ini

[qiluo-msft]

(Sorry, I should reply this thread)
Have you tested moving them inside container instead of in host? https://github.com/Azure/sonic-mgmt/blob/master/ansible/roles/sonicv2/tasks/quagga.yml has an example (see the 'block'). Roughly speaking, ansible can run any task directly in the container.

We try to move ssw directory into specific containers in future. We don't want to add more complexity if we have workaround. In this case, BRCM, MLNX don't need the new mounting point.

Sorry for the inconvenience. #Closed
#Closed

[NStetskovych-zz]

yes, will change in next commit.

[NStetskovych-zz]

removed

[qiluo-msft]

Missing this template file in the commit? Is the content static or dynamic? Can we build it into syncd_cavm docker image, so we can keep the syncd_docker_volumes_dict as simple as possible, also platform consistent. #Closed
#Closed

[NStetskovych-zz]

No, it is already merged in previous commit :) Here 49eee2d.

[qiluo-msft]

Thanks! I saw them. #Closed
#Closed

[NStetskovych-zz]

By ansible template we can dynamically generate profile for different port speed. Is it so bad to share /etc/ssw to one more container?

[qiluo-msft]

We try to move ssw directory into specific containers in future. We don't want to add more complexity if we have workaround.

In this case, at least BRCM, MLNX don't need the new mounting point. #Closed
#Closed

[NStetskovych-zz]

Ok, got it :)

[NStetskovych-zz]

Done. Now it built into syncd_cavm docker image.

[NStetskovych-zz]

@lguohan @qiluo-msft Do I miss sth to correct?

[qiluo-msft]

Let me clarify my points. I guess your requirements are:

1. In the orchagent container, you will need a file "port_config.ini", and you will never read the files "port_config_*.ini" directly
2. The content of the file "port_config.ini" is determined during deployment, and never changed on the switch box.

Since the requirement is different from all other vendors. Suggest not to follow the "Copy SSW files".

To keep it very clean and consistent, suggest you not put source files in ansible/roles/sonicv2/files/ssw/. Instead, create a 'copy' task in sonic-cavm.yml, and the src parameter will be determined based on the port sku variable. So you don't need to copy many files to switch, don't need to create a symlink at all. Below is a sample (please test before using:))

- name: Copy the port config file based on port sku
  copy:
    src: /etc/ssw_extra/{{ sonic_hwsku }}/port_config_{{ sonic_portsku }}.ini
    dest: /etc/ssw/{{ sonic_hwsku }}/port_config.ini

#Closed

[NStetskovych-zz]

@qiluo-msft please review.

[qiluo-msft]

Thanks @NStetskovych! One more question: can we remove ansible/roles/sonicv2/files/ssw/XP-SIM/*? I guess they are not used.

[NStetskovych-zz]

we used it for our 'virtual' SONiC. But here we can remove. Will remove.