[action] [PR:13314] Fix test_neighbor_mac on t1-lag and t1-64-lag#13608
Merged
mssonicbld merged 1 commit intosonic-net:202405from Jul 12, 2024
Merged
[action] [PR:13314] Fix test_neighbor_mac on t1-lag and t1-64-lag#13608mssonicbld merged 1 commit intosonic-net:202405from
mssonicbld merged 1 commit intosonic-net:202405from
Conversation
* Fix test_neighbor_mac on t1-lag and t1-64-lag A recent change sets this test to t1-only: sonic-net#12952 The test can pass on topo t1 without any change. For t1-lag or t1-64-lag, the Ethernet0 to test is in portchannel, so IP address cannot be set to it. The fix here is to delete the intf from the portchanenl before testing it.
8 tasks
Collaborator
Author
|
Original PR: #13314 |
Collaborator
Author
|
/azp run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
A recent change applies this test to the topo of t1 and t1-variants:
#12952
The test can pass on topo t1 without any change.
For t1-lag or t1-64-lag, the Ethernet0 to test is in portchannel, so IP address cannot be set to it.
How did you do it?
The fix here is to remove the intf from the portchanenl before testing it.
Skip the test if Ethernet0 is not available or down at the beginning of test
Assert Ethernet0 is in routed state after removing it from portchannel
How did you verify/test it?
Run the test on t1-lag and t1-64-lag topo.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation