Keep One Port Up in BGP Scale Test to Preserve PTF Reachability and Accurate Downtime#21979
Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom Feb 14, 2026
Conversation
Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
PriyanshTratiya
added
Request for msft-202412 Branch
Request for 202511 branch
r12f
approved these changes
Feb 3, 2026
Collaborator
r12f
left a comment
r12f
left a comment
There was a problem hiding this comment.
let's update the PR title to be explicit on what test this change is going to affect.
PriyanshTratiya
changed the title
Collaborator
|
Cherry-pick PR to 202511: #22457 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Feb 18, 2026
Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com> Signed-off-by: mssonicbld <sonicbld@microsoft.com>
mssonicbld
added
Included in 202511 branch
and removed
Created PR to 202511 branch
labels
anilal-amd
pushed a commit
to anilal-amd/anilal-forked-sonic-mgmt
that referenced
this pull request
Feb 19, 2026
11 tasks
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#1061 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
In IPv6 BGP scale flap testing, when
all_flapis enabled we must keep one neighbor stable avoid dataplane downtime miscalculation. This PR updates the target selection logic to flap “all minus one” neighbors by removing the randomly chosen injection neighbor from the flapping neighbor list, and updates the log message accordingly.Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
The flap test requires a dedicated “injection neighbor” to remain up for route injection/verification. Previously, with
all_flap=True, the injection neighbor could also be included in the flapping set, causing inconsistent/incorrect behavior.How did you do it?
In
tests/bgp/test_ipv6_bgp_scale.py(_select_targets_to_flap), whenall_flapis enabled:list(bgp_neighbors)) to avoid aliasing.flapping_neighborsso we flap all other neighbors.How did you verify/test it?
Ran the tests on Arista 7060X6 and Mellanox SN5640
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation