[action] [PR:21979] Keep One Port Up in BGP Scale Test to Preserve PTF Reachability and Accurate Downtime#1061
Merged
mssonicbld merged 1 commit intoAzure:202412from Mar 12, 2026
Conversation
…ccurate Downtime <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: In IPv6 BGP scale flap testing, when `all_flap` is enabled we must keep one neighbor stable avoid dataplane downtime miscalculation. This PR updates the target selection logic to flap “all minus one” neighbors by removing the randomly chosen injection neighbor from the flapping neighbor list, and updates the log message accordingly. Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ x ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [ ] 202511 ### Approach #### What is the motivation for this PR? The flap test requires a dedicated “injection neighbor” to remain up for route injection/verification. Previously, with `all_flap=True`, the injection neighbor could also be included in the flapping set, causing inconsistent/incorrect behavior. #### How did you do it? In `tests/bgp/test_ipv6_bgp_scale.py` (`_select_targets_to_flap`), when `all_flap` is enabled: - Copy the neighbor list (`list(bgp_neighbors)`) to avoid aliasing. - Randomly pick the injection neighbor. - Remove the injection neighbor from `flapping_neighbors` so we flap all other neighbors. - Update the log message to reflect “All - 1 neighbors”. #### How did you verify/test it? Ran the tests on Arista 7060X6 and Mellanox SN5640 #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
Collaborator
Author
|
Original PR: sonic-net/sonic-mgmt#21979 |
Collaborator
Author
|
/azp run |
11 tasks
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
In IPv6 BGP scale flap testing, when
all_flapis enabled we must keep one neighbor stable avoid dataplane downtime miscalculation. This PR updates the target selection logic to flap “all minus one” neighbors by removing the randomly chosen injection neighbor from the flapping neighbor list, and updates the log message accordingly.Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
The flap test requires a dedicated “injection neighbor” to remain up for route injection/verification. Previously, with
all_flap=True, the injection neighbor could also be included in the flapping set, causing inconsistent/incorrect behavior.How did you do it?
In
tests/bgp/test_ipv6_bgp_scale.py(_select_targets_to_flap), whenall_flapis enabled:list(bgp_neighbors)) to avoid aliasing.flapping_neighborsso we flap all other neighbors.How did you verify/test it?
Ran the tests on Arista 7060X6 and Mellanox SN5640
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation
Signed-off-by: Sonic Build Admin sonicbld@microsoft.com