Skip to content

Moving excluded scripts from excludes list to test_mark_conditional.yml #21674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StormLiangMS merged 3 commits into from
Jan 8, 2026
Merged

Moving excluded scripts from excludes list to test_mark_conditional.yml #21674

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b8ff53
added_scripts
bachalla Dec 12, 2025
6cbba15
fixed_comments
bachalla Dec 16, 2025
1b23cca
fixed_comments
bachalla Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions tests/common/plugins/conditional_mark/tests_mark_conditions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3468,12 +3468,13 @@ mvrf:

mvrf/test_mgmtvrf.py:
skip:
reason: "mvrf is not supported in x86_64-nokia_ixr7250e_36x400g-r0 platform, M* topo, kvm testbed, mellanox, nvidia and broadcom asic from 202411 and later"
reason: "mvrf is not supported in x86_64-nokia_ixr7250e_36x400g-r0 platform, M* topo, kvm testbed, mellanox, nvidia and broadcom asic from 202411 and later and test skipped due to github issue #3589"
conditions_logical_operator: or
conditions:
- "asic_type in ['vs', 'mellanox', 'nvidia', 'broadcom']"
- "topo_type in ['m0', 'mx', 'm1']"
- "platform in ['x86_64-nokia_ixr7250e_36x400g-r0']"
- https://github.com/sonic-net/sonic-mgmt/issues/3589
Copy link
Copy Markdown
Collaborator

@bingwang-ms bingwang-ms Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is quote required for github issue link?

Copy link
Copy Markdown
Contributor Author

@bachalla bachalla Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bingwang-ms yes, quote is required,Thanks! for your suggestion


mvrf/test_mgmtvrf.py::TestReboot::test_fastboot:
skip:
Expand Down Expand Up @@ -4372,6 +4373,14 @@ scripts:
#######################################
##### sflow #####
#######################################
sflow/test_sflow.py:
skip:
reason: "It is not supported on this DUT topology and skipped due to github issue #21701"
conditions_logical_operator: or
conditions:
- "'t0', 'm0', 'mx' not in topo_name"
Copy link
Copy Markdown
Contributor

@ZhaohuiS ZhaohuiS Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this command has syntax error, and why do you want to add this line?

Copy link
Copy Markdown
Contributor Author

@bachalla bachalla Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZhaohuiS Ill remove this line, as per your suggestion

- "https://github.com/sonic-net/sonic-mgmt/issues/21701"

sflow/test_sflow.py::TestReboot::testFastreboot:
skip:
reason: "Dualtor topology doesn't support advanced-reboot"
Expand Down Expand Up @@ -5054,11 +5063,13 @@ voq/test_voq_fabric_status_all.py:
#######################################
vrf/test_vrf.py:
skip:
reason: "Vrf tests are skipped in PR testing, not supported on mellanox and nvidia asic from 202411 and later, not support for non t0 topology currently"
reason: "Vrf tests are skipped in PR testing, not supported on mellanox and nvidia asic from 202411 and later, not support for non t0 topology currently and skipped due to github issue #21700"
conditions_logical_operator: or
conditions:
- "asic_type in ['vs', 'mellanox', 'nvidia']"
- "topo_type not in ['t0']"
- "https://github.com/sonic-net/sonic-mgmt/issues/21700"

Copy link
Copy Markdown
Collaborator

@StormLiangMS StormLiangMS Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @bachalla could you remove the line 5070?

Copy link
Copy Markdown
Contributor Author

@bachalla bachalla Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @StormLiangMS ,I have removed this line as per your suggestion,Thanks!


vrf/test_vrf.py::TestVrfAclRedirect:
skip:
Expand All @@ -5082,11 +5093,12 @@ vrf/test_vrf.py::TestVrfWarmReboot::test_vrf_system_warm_reboot:

vrf/test_vrf_attr.py:
skip:
reason: "Vrf tests are skipped in PR testing, not supported on mellanox and nvidia asic from 202411 and later, not support for non t0 topology currently"
reason: "Vrf tests are skipped in PR testing, not supported on mellanox and nvidia asic from 202411 and later, not support for non t0 topology currently and skipped due to github issue #21700"
conditions_logical_operator: or
conditions:
- "asic_type in ['vs', 'mellanox', 'nvidia']"
- "topo_type not in ['t0']"
- "https://github.com/sonic-net/sonic-mgmt/issues/21700"

vrf/test_vrf_attr.py::TestVrfAttrSrcMac::test_vrf1_neigh_with_default_router_mac:
skip:
Expand Down
Loading