Moving excluded scripts from excludes list to test_mark_conditional.yml by bachalla · Pull Request #21674 · sonic-net/sonic-mgmt

bachalla · 2025-12-12T08:13:34Z

Description of PR

Type of change

Back port request

Summary:
Moving excluded scripts from excludes list to test_conditional_mark.yml .This improves debuggability and speeds up issue resolution.

What is the motivation for this PR?
The motivation is to moving excluded scripts from excludes list to test_conditional_mark.yml

How did you do it?
I moved excluded scripts from excludes list and updated to test_conditional_mark.yml

How did you verify/test it?
Verified that the updated messages are correctly reflected in the test_conditional_mark.yml by reviewing the changes locally.

mssonicbld · 2025-12-12T08:13:42Z

/azp run

azure-pipelines · 2025-12-12T08:13:56Z

Azure Pipelines successfully started running 1 pipeline(s).

ZhaohuiS · 2025-12-12T13:04:31Z

tests/common/plugins/conditional_mark/tests_mark_conditions.yaml

      - "asic_type in ['vs', 'mellanox', 'nvidia', 'broadcom']"
      - "topo_type in ['m0', 'mx', 'm1']"
      - "platform in ['x86_64-nokia_ixr7250e_36x400g-r0']"
+      - "release in ['202412']"


use github issue to skip. For mvrf, use this issue Need new test: System and Management - VRF support for management interface · Issue #3589 · sonic-n…

for vrf and sflow, please open another 2 new slimilar issues to track

@ZhaohuiS I have done changes as per your suggestion,Thanks!

mssonicbld · 2025-12-15T08:59:00Z

/azp run

azure-pipelines · 2025-12-15T08:59:14Z

Azure Pipelines successfully started running 1 pipeline(s).

ZhaohuiS · 2025-12-16T02:08:33Z

tests/common/plugins/conditional_mark/tests_mark_conditions.yaml

+    reason: "It is not supported on this DUT topology  and skipped due to github issue #21701"
+    conditions_logical_operator: or
+    conditions:
+      - "'t0', 'm0', 'mx' not in topo_name"


this command has syntax error, and why do you want to add this line?

@ZhaohuiS Ill remove this line, as per your suggestion

mssonicbld · 2025-12-16T08:18:36Z

/azp run

azure-pipelines · 2025-12-16T08:18:50Z

Azure Pipelines successfully started running 1 pipeline(s).

ZhaohuiS · 2025-12-16T13:26:22Z

@prsunny @bingwang-ms @StormLiangMS could you please help review this PR?

bingwang-ms · 2025-12-16T17:21:31Z

tests/common/plugins/conditional_mark/tests_mark_conditions.yaml

      - "asic_type in ['vs', 'mellanox', 'nvidia', 'broadcom']"
      - "topo_type in ['m0', 'mx', 'm1']"
      - "platform in ['x86_64-nokia_ixr7250e_36x400g-r0']"
+      -  https://github.com/sonic-net/sonic-mgmt/issues/3589


Is quote required for github issue link?

@bingwang-ms yes, quote is required,Thanks! for your suggestion

bingwang-ms · 2025-12-16T17:25:54Z

Hi @ZhaohuiS, is this PR to move skipped tests from excluded list in pipeline setting to test_mark_conditional.yml? If that's the case, I would suggest using some other skip condition instead of github issue because we have a plan to cleanup skipped test because of test issue.

ZhaohuiS · 2025-12-17T06:20:15Z

Hi @ZhaohuiS, is this PR to move skipped tests from excluded list in pipeline setting to test_mark_conditional.yml? If that's the case, I would suggest using some other skip condition instead of github issue because we have a plan to cleanup skipped test because of test issue.

Hi @bingwang-ms currently, those 4 scripts are running on Arista platforms, I am not sure if we have to skip it or need to address those failures to make them pass, so add a github issue(test gap) to skip them temporarily. If you can confirm that they are indeed to be skipped, then I am fine to use other skip condition to do that. That's why it needs feature owner to review it and give us some feedback how to handle them correctly.

mssonicbld · 2025-12-17T10:31:17Z

/azp run

azure-pipelines · 2025-12-17T10:31:31Z

Azure Pipelines successfully started running 1 pipeline(s).

ZhaohuiS · 2025-12-30T02:03:49Z

@bachalla pls fix the failures in the PR test and get it merged.

mssonicbld · 2026-01-02T13:27:34Z

/azp run

azure-pipelines · 2026-01-02T13:27:49Z

Azure Pipelines successfully started running 1 pipeline(s).

ZhaohuiS

looks good to me

ZhaohuiS · 2026-01-04T08:25:24Z

@StormLiangMS could you pls help review this PR? we temporally skip those scripts by opening issue to track them.

StormLiangMS · 2026-01-05T02:29:18Z

tests/common/plugins/conditional_mark/tests_mark_conditions.yaml

      - "asic_type in ['vs', 'mellanox', 'nvidia']"
      - "topo_type not in ['t0']"
+      - "https://github.com/sonic-net/sonic-mgmt/issues/21700"
+


hi @bachalla could you remove the line 5070?

Hello @StormLiangMS ,I have removed this line as per your suggestion,Thanks!

mssonicbld · 2026-01-05T09:43:40Z

/azp run

azure-pipelines · 2026-01-05T09:43:55Z

Azure Pipelines successfully started running 1 pipeline(s).

StormLiangMS

LGTM

…ml (sonic-net#21674) Summary: Moving excluded scripts from excludes list to test_conditional_mark.yml .This improves debuggability and speeds up issue resolution. What is the motivation for this PR? The motivation is to moving excluded scripts from excludes list to test_conditional_mark.yml How did you do it? I moved excluded scripts from excludes list and updated to test_conditional_mark.yml How did you verify/test it? Verified that the updated messages are correctly reflected in the test_conditional_mark.yml by reviewing the changes locally.

…ml (sonic-net#21674) Summary: Moving excluded scripts from excludes list to test_conditional_mark.yml .This improves debuggability and speeds up issue resolution. What is the motivation for this PR? The motivation is to moving excluded scripts from excludes list to test_conditional_mark.yml How did you do it? I moved excluded scripts from excludes list and updated to test_conditional_mark.yml How did you verify/test it? Verified that the updated messages are correctly reflected in the test_conditional_mark.yml by reviewing the changes locally. Signed-off-by: YiFan Wang <[email protected]>

…ml (sonic-net#21674) Summary: Moving excluded scripts from excludes list to test_conditional_mark.yml .This improves debuggability and speeds up issue resolution. What is the motivation for this PR? The motivation is to moving excluded scripts from excludes list to test_conditional_mark.yml How did you do it? I moved excluded scripts from excludes list and updated to test_conditional_mark.yml How did you verify/test it? Verified that the updated messages are correctly reflected in the test_conditional_mark.yml by reviewing the changes locally. Signed-off-by: Priyansh Tratiya <[email protected]>

…ml (sonic-net#21674) Summary: Moving excluded scripts from excludes list to test_conditional_mark.yml .This improves debuggability and speeds up issue resolution. What is the motivation for this PR? The motivation is to moving excluded scripts from excludes list to test_conditional_mark.yml How did you do it? I moved excluded scripts from excludes list and updated to test_conditional_mark.yml How did you verify/test it? Verified that the updated messages are correctly reflected in the test_conditional_mark.yml by reviewing the changes locally. Signed-off-by: Yael Tzur <[email protected]>

…ml (sonic-net#21674) Summary: Moving excluded scripts from excludes list to test_conditional_mark.yml .This improves debuggability and speeds up issue resolution. What is the motivation for this PR? The motivation is to moving excluded scripts from excludes list to test_conditional_mark.yml How did you do it? I moved excluded scripts from excludes list and updated to test_conditional_mark.yml How did you verify/test it? Verified that the updated messages are correctly reflected in the test_conditional_mark.yml by reviewing the changes locally.

vhlushko-cisco · 2026-02-11T12:14:42Z

@StormLiangMS @bachalla could you please cherry-pick it in 202511 branch?

…ml (sonic-net#21674) Summary: Moving excluded scripts from excludes list to test_conditional_mark.yml .This improves debuggability and speeds up issue resolution. What is the motivation for this PR? The motivation is to moving excluded scripts from excludes list to test_conditional_mark.yml How did you do it? I moved excluded scripts from excludes list and updated to test_conditional_mark.yml How did you verify/test it? Verified that the updated messages are correctly reflected in the test_conditional_mark.yml by reviewing the changes locally. Signed-off-by: nnelluri-cisco <[email protected]>

…ml (sonic-net#21674) Summary: Moving excluded scripts from excludes list to test_conditional_mark.yml .This improves debuggability and speeds up issue resolution. What is the motivation for this PR? The motivation is to moving excluded scripts from excludes list to test_conditional_mark.yml How did you do it? I moved excluded scripts from excludes list and updated to test_conditional_mark.yml How did you verify/test it? Verified that the updated messages are correctly reflected in the test_conditional_mark.yml by reviewing the changes locally. Signed-off-by: Raghavendran Ramanathan <[email protected]>

vhlushko-cisco · 2026-02-16T09:41:31Z

@StormLiangMS @bachalla could you please cherry-pick it in 202511 branch?

…ml (sonic-net#21674) Summary: Moving excluded scripts from excludes list to test_conditional_mark.yml .This improves debuggability and speeds up issue resolution. What is the motivation for this PR? The motivation is to moving excluded scripts from excludes list to test_conditional_mark.yml How did you do it? I moved excluded scripts from excludes list and updated to test_conditional_mark.yml How did you verify/test it? Verified that the updated messages are correctly reflected in the test_conditional_mark.yml by reviewing the changes locally. Signed-off-by: Zhuohui Tan <[email protected]>

vhlushko-cisco · 2026-02-20T17:01:32Z

@StormLiangMS @bachalla could you please cherry-pick it in 202511 branch?

eyakubch · 2026-02-23T10:49:37Z

@bachalla can you please merge to 202511 also ?

…ml (sonic-net#21674) Summary: Moving excluded scripts from excludes list to test_conditional_mark.yml .This improves debuggability and speeds up issue resolution. What is the motivation for this PR? The motivation is to moving excluded scripts from excludes list to test_conditional_mark.yml How did you do it? I moved excluded scripts from excludes list and updated to test_conditional_mark.yml How did you verify/test it? Verified that the updated messages are correctly reflected in the test_conditional_mark.yml by reviewing the changes locally. Signed-off-by: Abhishek <[email protected]>

github-actions bot requested review from BYGX-wcr, xwjiang-ms and yutongzhang-microsoft December 12, 2025 08:13

ZhaohuiS reviewed Dec 12, 2025

View reviewed changes

added_scripts

9b8ff53

bachalla force-pushed the script branch from e78b659 to 9b8ff53 Compare December 15, 2025 08:58

ZhaohuiS reviewed Dec 16, 2025

View reviewed changes

ZhaohuiS requested review from StormLiangMS, bingwang-ms and prsunny December 16, 2025 13:25

bingwang-ms reviewed Dec 16, 2025

View reviewed changes

fixed_comments

6cbba15

bachalla force-pushed the script branch from d2c509f to 6cbba15 Compare December 17, 2025 10:31

bachalla closed this Jan 2, 2026

bachalla reopened this Jan 2, 2026

ZhaohuiS approved these changes Jan 4, 2026

View reviewed changes

StormLiangMS reviewed Jan 5, 2026

View reviewed changes

fixed_comments

1b23cca

StormLiangMS approved these changes Jan 8, 2026

View reviewed changes

StormLiangMS merged commit 10820b8 into sonic-net:master Jan 8, 2026
20 of 21 checks passed

vkjammala-arista mentioned this pull request Mar 12, 2026

[sonic-mgmt] Fix sflow/test_sflow.py failures with expected sflow packets not received on collector interface #22186

Merged

12 tasks

Conversation

bachalla commented Dec 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mssonicbld commented Dec 12, 2025

Uh oh!

azure-pipelines bot commented Dec 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Dec 15, 2025

Uh oh!

azure-pipelines bot commented Dec 15, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Dec 16, 2025

Uh oh!

azure-pipelines bot commented Dec 16, 2025

Uh oh!

ZhaohuiS commented Dec 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bingwang-ms commented Dec 16, 2025

Uh oh!

ZhaohuiS commented Dec 17, 2025

Uh oh!

mssonicbld commented Dec 17, 2025

Uh oh!

azure-pipelines bot commented Dec 17, 2025

Uh oh!

ZhaohuiS commented Dec 30, 2025

Uh oh!

mssonicbld commented Jan 2, 2026

Uh oh!

azure-pipelines bot commented Jan 2, 2026

Uh oh!

ZhaohuiS left a comment

Choose a reason for hiding this comment

Uh oh!

ZhaohuiS commented Jan 4, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mssonicbld commented Jan 5, 2026

Uh oh!

azure-pipelines bot commented Jan 5, 2026

Uh oh!

StormLiangMS left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vhlushko-cisco commented Feb 11, 2026

Uh oh!

vhlushko-cisco commented Feb 16, 2026

Uh oh!

vhlushko-cisco commented Feb 20, 2026

Uh oh!

eyakubch commented Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

bachalla commented Dec 12, 2025 •

edited

Loading