Skip to content

[manual] [PR:21614] fix: enhance routeCheck toggle logic#21673

Merged
wangxin merged 2 commits intosonic-net:202411from
cyw233:cherry/202411/21614
Dec 22, 2025
Merged

[manual] [PR:21614] fix: enhance routeCheck toggle logic#21673
wangxin merged 2 commits intosonic-net:202411from
cyw233:cherry/202411/21614

Conversation

@cyw233
Copy link
Copy Markdown
Contributor

@cyw233 cyw233 commented Dec 12, 2025

Description of PR

Further enhance the routeCheck monitor disable-and-enable logic:

  • Users can choose which topologies apply the disable-and-enable routeCheck behavior
  • Use wait_until() timeout to verify the routeCheck status is as expected before proceeding to the next step

Summary:
Fixes # (issue) Microsoft ADO 36101536

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

Approach

What is the motivation for this PR?

This is a follow-up PR of #21582. Not all platforms need the "temporarily disable roureCheck monitor" feature, and the routeCheck monitor will take some time to startup after running sudo monit start routeCheck on some platforms. Therefore, we want to allow the users to choose which topologies they want to apply the disable-and-enable routeCheck behavior (Now only T2, LT2 & UT2 are allowed). Besides, we added a wait_until() timeout to verify the routeCheck status is as expected before proceeding to the next step.

How did you do it?

How did you verify/test it?

I verified it on a T0 platform and I can confirm this logic will be skipped: https://elastictest.org/scheduler/testplan/69389f2d392767e9bf67ef1a

image image

I also verified on a T2 platform and I can confirm this logic is applied there: https://elastictest.org/scheduler/testplan/69389e7794f9e10e4c224c66

image image

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@cyw233
Copy link
Copy Markdown
Contributor Author

cyw233 commented Dec 12, 2025

Original PR: #21614

@cyw233 cyw233 mentioned this pull request Dec 12, 2025
12 tasks
@wangxin wangxin merged commit c82d8f7 into sonic-net:202411 Dec 22, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants