Skip to content

fix: disable route check for po cleanup test cases#21320

Merged
auspham merged 1 commit intosonic-net:masterfrom
cyw233:disable-route-checkf-for-po-cleanup
Nov 18, 2025
Merged

fix: disable route check for po cleanup test cases#21320
auspham merged 1 commit intosonic-net:masterfrom
cyw233:disable-route-checkf-for-po-cleanup

Conversation

@cyw233
Copy link
Contributor

@cyw233 cyw233 commented Nov 14, 2025

Description of PR

We are having a module level pytest.mark.disable_route_check marker in pc/test_po_cleanup.py test to temporarily disable the routeCheck monitor for the entire module. However, we are doing config_reload() in different test cases within this test module, and the routeCheck monitor will automatically startup after each config_reload().

Therefore, we want to keep the module level routeCheck disable marker (so the routeCheck monitor will always be started at the very end of the test module) and introduce an extra function-level routeCheck disable fixture to make sure the routeCheck monitor is always disabled before each test case.

Summary:
Fixes # (issue) Microsoft ADO 35884974

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

Disable the routeCheck monitor before each test case in pc/test_po_cleanup.py to avoid getting any noisy error syslog.

How did you do it?

Introduced a function-level fixture to disable routeCheck monitor.

How did you verify/test it?

I ran the updated code and can confirm it's working well: https://elastictest.org/scheduler/testplan/6916acddbf375d1f9e5d1333

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@cyw233 cyw233 requested review from a team and wangxin as code owners November 14, 2025 03:58
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cyw233 cyw233 marked this pull request as draft November 14, 2025 04:21
@cyw233 cyw233 force-pushed the disable-route-checkf-for-po-cleanup branch from 4a27059 to 3762ab5 Compare November 14, 2025 04:49
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cyw233 cyw233 marked this pull request as ready for review November 14, 2025 04:50
@cyw233 cyw233 force-pushed the disable-route-checkf-for-po-cleanup branch from 3762ab5 to 467db16 Compare November 14, 2025 04:56
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@auspham auspham merged commit 64adc80 into sonic-net:master Nov 18, 2025
19 checks passed
@cyw233
Copy link
Contributor Author

cyw233 commented Nov 18, 2025

Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#876

vikumarks pushed a commit to vikumarks/sonic-mgmt that referenced this pull request Dec 1, 2025
albertovillarreal-keys pushed a commit to albertovillarreal-keys/sonic-mgmt that referenced this pull request Dec 2, 2025
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
dcaugher pushed a commit to dcaugher/sonic-mgmt that referenced this pull request Dec 8, 2025
nissampa pushed a commit to nissampa/sonic-mgmt_dpu_test that referenced this pull request Dec 9, 2025
selldinesh pushed a commit to selldinesh/sonic-mgmt that referenced this pull request Dec 11, 2025
@mssonicbld
Copy link
Collaborator

@cyw233 PR conflicts with 202411 branch

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202505: #21661

@cyw233
Copy link
Contributor Author

cyw233 commented Dec 12, 2025

Will manually cherry-pick these changes to 202411 and 202505 in other PRs

cyw233 added a commit to cyw233/sonic-mgmt that referenced this pull request Dec 12, 2025
cyw233 added a commit to cyw233/sonic-mgmt that referenced this pull request Dec 12, 2025
echuawu pushed a commit to echuawu/sonic-mgmt that referenced this pull request Dec 12, 2025
saravanan-nexthop pushed a commit to saravanan-nexthop/sonic-mgmt that referenced this pull request Dec 15, 2025
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 16, 2025
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
yifan-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Jan 14, 2026
PriyanshTratiya pushed a commit to PriyanshTratiya/sonic-mgmt that referenced this pull request Jan 21, 2026
lakshmi-nexthop pushed a commit to lakshmi-nexthop/sonic-mgmt that referenced this pull request Jan 28, 2026
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Jan 29, 2026
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
abhishek-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Feb 6, 2026
rraghav-cisco pushed a commit to rraghav-cisco/sonic-mgmt that referenced this pull request Feb 13, 2026
anilal-amd pushed a commit to anilal-amd/anilal-forked-sonic-mgmt that referenced this pull request Feb 19, 2026
abhishek-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants