updata testbed playbook for ubuntu 17.04#216
Merged
lguohan merged 2 commits intosonic-net:masterfrom Jul 25, 2017
Merged
Conversation
TODO: * add docker deb gpg key * auto-generate p4p1 interface configuration
pavel-shirshov
suggested changes
Jul 24, 2017
ansible/ansible.cfg
Outdated
| fact_caching = memory | ||
| fact_caching = jsonfile | ||
| fact_caching_connection = ~/.ansible/cache | ||
| fact_caching_timeout = 86400 |
Contributor
There was a problem hiding this comment.
I think it's too long to cache all facts to one day. What if some interface was up and now it's down?
We should be able to track such things from our playbook.
Contributor
Author
There was a problem hiding this comment.
we are really using those data. the only data we need is the kernel version and distribution, I'll decrease it to 10 minutes.
Contributor
There was a problem hiding this comment.
But ansible.cfg is global.
Our tests can use ansible facts extensively.
| - ansible_distribution_version == "17.04" | ||
| - ansible_kernel.find('4.10.0') != -1 | ||
| - "{{ ansible_kernel | regex_replace('4.10.0-([0-9]+)-.*', '\\1') | int < 25 }}" | ||
|
|
Contributor
There was a problem hiding this comment.
Why do we need to make this kernel upgrade? Can you please leave a comment?
|
|
||
| - name: Install br_netfilter kernel module | ||
| become: yes | ||
| modprobe: name=br_netfilter state=present |
Contributor
There was a problem hiding this comment.
Why do we need br_netfilter?
Contributor
Author
There was a problem hiding this comment.
in roles/vm_set/test/start.yml
""
- name: Set sysctl bridge parameters for testbed
sysctl:
name: "{{ item }}"
value: 0
sysctl_set: yes
become: yes
with_items:- net.bridge.bridge-nf-call-arptables
- net.bridge.bridge-nf-call-ip6tables
- net.bridge.bridge-nf-call-iptables
"""
Contributor
|
to ToDo |
Contributor
Author
|
I'll list p4p1 as a manual step to prepare the box. I cannot find a way to include it in the playbook. I do not know which device to be p4p1. |
pavel-shirshov
approved these changes
Jul 25, 2017
lguohan
added a commit
that referenced
this pull request
Aug 3, 2017
* updata testbed playbook for ubuntu 17.04 TODO: * add docker deb gpg key * auto-generate p4p1 interface configuration
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
May 30, 2025
What is the motivation for this PR? How did you do it? How did you verify/test it? For test, refer to https://github.com/yutongzhang-microsoft/sonic-mgmt/actions/runs/14565246169/job/40853553502 Any platform specific information? Supported testbed topology if it's a new test case?
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…ate (sonic-net#8864) * [202012][sonic-platform-daemons] submodule update 3d14066 [xcvrd][y_cable] refactor xcvrd to listen to port probe without locks; fix the get_firmware_version API to sync with download_firmware (sonic-net#216) Signed-off-by: vaibhav-dahiya <[email protected]> * update sonic-platform-common 93244bf [Y-Cable][Broadcom] upgrade to support Broadcom Y-Cable API to release 1.2 (sonic-net#217) Signed-off-by: vaibhav-dahiya <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
sonic-net#16474) src/linkmgrd * 4bf3ebb - (HEAD -> 202205, origin/202205) [active-standby] Fix extra toggle observed in `config reload` (sonic-net#216) (53 minutes ago) [Longxiang Lyu]
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
sonic-net#16152) #### Why I did it src/linkmgrd ``` * 40113fd - (HEAD -> 202305, origin/202305) [active-standby] Fix extra toggle observed in `config reload` (sonic-net#216) (2 days ago) [Longxiang Lyu] * b6d40fc - Add ADO to the PR template (sonic-net#215) (2 days ago) [Longxiang Lyu] * fe41ad2 - [active-standby] Write `unhealthy` is default route `N/A` (sonic-net#214) (2 days ago) [Longxiang Lyu] * 8ff265c - [link prober] Increase pause/restart probe log verbosity (sonic-net#213) (2 days ago) [Longxiang Lyu] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: