Cisco-8000:Snappi:Fix the arp deletion code in cisco-8000 fixture.#21064
Merged
yejianquan merged 2 commits intosonic-net:masterfrom Oct 25, 2025
Merged
Cisco-8000:Snappi:Fix the arp deletion code in cisco-8000 fixture.#21064yejianquan merged 2 commits intosonic-net:masterfrom
yejianquan merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
auspham
approved these changes
Oct 22, 2025
sdszhang
approved these changes
Oct 22, 2025
dcaugher
pushed a commit
to dcaugher/sonic-mgmt
that referenced
this pull request
Nov 12, 2025
…onic-net#21064) Description of PR Summary: In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete. How did you do it? By calculating the correct arguments to the arp delete. How did you verify/test it? Ran it on T1 and T2 devices. Any platform specific information? Specific to cisco-8000 only. @sdszhang , @auspham : FYI. ssigned-off-by: [email protected]
dcaugher
pushed a commit
to dcaugher/sonic-mgmt
that referenced
this pull request
Nov 12, 2025
…onic-net#21064) Description of PR Summary: In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete. How did you do it? By calculating the correct arguments to the arp delete. How did you verify/test it? Ran it on T1 and T2 devices. Any platform specific information? Specific to cisco-8000 only. @sdszhang , @auspham : FYI. ssigned-off-by: [email protected]
11 tasks
Collaborator
|
Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#865 |
mssonicbld
added
Included in msft-202405 Branch
and removed
Created PR to msft-202405 Branch
labels
vikumarks
pushed a commit
to vikumarks/sonic-mgmt
that referenced
this pull request
Dec 1, 2025
…onic-net#21064) Description of PR Summary: In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete. How did you do it? By calculating the correct arguments to the arp delete. How did you verify/test it? Ran it on T1 and T2 devices. Any platform specific information? Specific to cisco-8000 only. @sdszhang , @auspham : FYI. ssigned-off-by: [email protected] Signed-off-by: vikumarks <[email protected]>
albertovillarreal-keys
pushed a commit
to albertovillarreal-keys/sonic-mgmt
that referenced
this pull request
Dec 2, 2025
…onic-net#21064) Description of PR Summary: In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete. How did you do it? By calculating the correct arguments to the arp delete. How did you verify/test it? Ran it on T1 and T2 devices. Any platform specific information? Specific to cisco-8000 only. @sdszhang , @auspham : FYI. ssigned-off-by: [email protected] Signed-off-by: Alberto Villarreal <[email protected]>
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…onic-net#21064) Description of PR Summary: In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete. How did you do it? By calculating the correct arguments to the arp delete. How did you verify/test it? Ran it on T1 and T2 devices. Any platform specific information? Specific to cisco-8000 only. @sdszhang , @auspham : FYI. ssigned-off-by: [email protected] Signed-off-by: opcoder0 <[email protected]>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Dec 11, 2025
…onic-net#21064) Description of PR Summary: In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete. How did you do it? By calculating the correct arguments to the arp delete. How did you verify/test it? Ran it on T1 and T2 devices. Any platform specific information? Specific to cisco-8000 only. @sdszhang , @auspham : FYI. ssigned-off-by: [email protected] Signed-off-by: selldinesh <[email protected]>
echuawu
pushed a commit
to echuawu/sonic-mgmt
that referenced
this pull request
Dec 12, 2025
…onic-net#21064) Description of PR Summary: In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete. How did you do it? By calculating the correct arguments to the arp delete. How did you verify/test it? Ran it on T1 and T2 devices. Any platform specific information? Specific to cisco-8000 only. @sdszhang , @auspham : FYI. ssigned-off-by: [email protected]
saravanan-nexthop
pushed a commit
to saravanan-nexthop/sonic-mgmt
that referenced
this pull request
Dec 15, 2025
…onic-net#21064) Description of PR Summary: In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete. How did you do it? By calculating the correct arguments to the arp delete. How did you verify/test it? Ran it on T1 and T2 devices. Any platform specific information? Specific to cisco-8000 only. @sdszhang , @auspham : FYI. ssigned-off-by: [email protected] Signed-off-by: Saravanan <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…onic-net#21064) Description of PR Summary: In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete. How did you do it? By calculating the correct arguments to the arp delete. How did you verify/test it? Ran it on T1 and T2 devices. Any platform specific information? Specific to cisco-8000 only. @sdszhang , @auspham : FYI. ssigned-off-by: [email protected] Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…onic-net#21064) Description of PR Summary: In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete. How did you do it? By calculating the correct arguments to the arp delete. How did you verify/test it? Ran it on T1 and T2 devices. Any platform specific information? Specific to cisco-8000 only. @sdszhang , @auspham : FYI. ssigned-off-by: [email protected] Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…onic-net#21064) Description of PR Summary: In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete. How did you do it? By calculating the correct arguments to the arp delete. How did you verify/test it? Ran it on T1 and T2 devices. Any platform specific information? Specific to cisco-8000 only. @sdszhang , @auspham : FYI. ssigned-off-by: [email protected] Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…onic-net#21064) Description of PR Summary: In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete. How did you do it? By calculating the correct arguments to the arp delete. How did you verify/test it? Ran it on T1 and T2 devices. Any platform specific information? Specific to cisco-8000 only. @sdszhang , @auspham : FYI. ssigned-off-by: [email protected]
yifan-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Jan 14, 2026
…onic-net#21064) Description of PR Summary: In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete. How did you do it? By calculating the correct arguments to the arp delete. How did you verify/test it? Ran it on T1 and T2 devices. Any platform specific information? Specific to cisco-8000 only. @sdszhang , @auspham : FYI. ssigned-off-by: [email protected] Signed-off-by: YiFan Wang <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…onic-net#21064) Description of PR Summary: In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete. How did you do it? By calculating the correct arguments to the arp delete. How did you verify/test it? Ran it on T1 and T2 devices. Any platform specific information? Specific to cisco-8000 only. @sdszhang , @auspham : FYI. ssigned-off-by: [email protected] Signed-off-by: Guy Shemesh <[email protected]>
lakshmi-nexthop
pushed a commit
to lakshmi-nexthop/sonic-mgmt
that referenced
this pull request
Jan 28, 2026
…onic-net#21064) Description of PR Summary: In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete. How did you do it? By calculating the correct arguments to the arp delete. How did you verify/test it? Ran it on T1 and T2 devices. Any platform specific information? Specific to cisco-8000 only. @sdszhang , @auspham : FYI. ssigned-off-by: [email protected] Signed-off-by: Lakshmi Yarramaneni <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Jan 29, 2026
…onic-net#21064) Description of PR Summary: In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete. How did you do it? By calculating the correct arguments to the arp delete. How did you verify/test it? Ran it on T1 and T2 devices. Any platform specific information? Specific to cisco-8000 only. @sdszhang , @auspham : FYI. ssigned-off-by: [email protected]
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…onic-net#21064) Description of PR Summary: In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete. How did you do it? By calculating the correct arguments to the arp delete. How did you verify/test it? Ran it on T1 and T2 devices. Any platform specific information? Specific to cisco-8000 only. @sdszhang , @auspham : FYI. ssigned-off-by: [email protected] Signed-off-by: Yael Tzur <[email protected]>
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Feb 6, 2026
…onic-net#21064) Description of PR Summary: In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete. How did you do it? By calculating the correct arguments to the arp delete. How did you verify/test it? Ran it on T1 and T2 devices. Any platform specific information? Specific to cisco-8000 only. @sdszhang , @auspham : FYI. ssigned-off-by: [email protected]
rraghav-cisco
added a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Feb 13, 2026
…onic-net#21064) Description of PR Summary: In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete. Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 Approach What is the motivation for this PR? The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete. How did you do it? By calculating the correct arguments to the arp delete. How did you verify/test it? Ran it on T1 and T2 devices. Any platform specific information? Specific to cisco-8000 only. @sdszhang , @auspham : FYI. ssigned-off-by: [email protected] Signed-off-by: Raghavendran Ramanathan <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
… automatically (sonic-net#21064) #### Why I did it src/sonic-platform-common ``` * ca6ab94 - (HEAD -> 202311, origin/202311) Implement get/set_lpmode API for SFF8472 (sonic-net#512) (22 hours ago) [byu343] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete.
Type of change
Back port request
Approach
What is the motivation for this PR?
The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete.
How did you do it?
By calculating the correct arguments to the arp delete.
How did you verify/test it?
Ran it on T1 and T2 devices.
Any platform specific information?
Specific to cisco-8000 only.
@sdszhang , @auspham : FYI.