[action] [PR:21064] Cisco-8000:Snappi:Fix the arp deletion code in cisco-8000 fixture.#865
Merged
mssonicbld merged 1 commit intoAzure:202405from Nov 13, 2025
Merged
Conversation
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [X] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [x] 202405 - [x] 202411 - [x] 202505 ### Approach #### What is the motivation for this PR? The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete. #### How did you do it? By calculating the correct arguments to the arp delete. #### How did you verify/test it? Ran it on T1 and T2 devices. #### Any platform specific information? Specific to cisco-8000 only. @sdszhang , @auspham : FYI.
Collaborator
Author
|
Original PR: sonic-net/sonic-mgmt#21064 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Merged
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
In the cisco-specific function: gen_data_flow_dest_ip(), we also have a code to delete arp entries created by the same function. But that code is not really correct. It was not caught due to the try-except block protecting it. Essentially, the arguments to the arp delete CLI is wrong. This PR fixes this issue, with the correct arguments to the arp delete.
Type of change
Back port request
Approach
What is the motivation for this PR?
The arp delete will not work with the current code. This PR is fixing the arguments to the arp delete.
How did you do it?
By calculating the correct arguments to the arp delete.
How did you verify/test it?
Ran it on T1 and T2 devices.
Any platform specific information?
Specific to cisco-8000 only.
@sdszhang , @auspham : FYI.