Skip to content

Improve setup-container.sh for Ubuntu 24.04 based docker-sonic-mgmt #20761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StormLiangMS merged 1 commit into from
Sep 23, 2025
Merged

Improve setup-container.sh for Ubuntu 24.04 based docker-sonic-mgmt #20761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions setup-container.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,11 @@ FROM {{ IMAGE_ID }}

USER root

# Remove possible default ubuntu user of Ubuntu 24.04
RUN if getent passwd ubuntu; \
then userdel -r ubuntu; \
fi

# Group configuration
RUN if getent group {{ GROUP_NAME }}; \
then groupmod -o -g {{ GROUP_ID }} {{ GROUP_NAME }}; \
Expand Down Expand Up @@ -269,9 +274,11 @@ WORKDIR ${HOME}
# 2. The user is not AzDevOps. By default python3 virtual env is installed for AzDevOps user.
# No need to install it again when current user is AzDevOps.
# 3. The python3 virtual env is not installed for AzDevOps. Then, it is not required for other users either.
RUN if ! pip3 list | grep -c pytest >/dev/null && \
[ '{{ USER_NAME }}' != 'AzDevOps' ] && \
[ -d /var/AzDevOps/env-python3 ]; then \
# As of 2025, python3 is installed globally in the docker-sonic-mgmt image. So, this step is not really required.
# Adjust the conditions to fail faster to skip this step.
RUN if [ -d /var/AzDevOps/env-python3 ] \
&& [ '{{ USER_NAME }}' != 'AzDevOps' ] \
&& ! pip3 list | grep -c pytest >/dev/null; then \
/bin/bash -c 'python3 -m venv ${HOME}/env-python3'; \
/bin/bash -c '${HOME}/env-python3/bin/pip install pip --upgrade'; \
/bin/bash -c '${HOME}/env-python3/bin/pip install wheel'; \
Expand Down