Skip to content

[action] [PR:16936] [platform] Fix the test_status_led error in case if the chassis led is not controllable#20143

Merged
mssonicbld merged 1 commit intosonic-net:202505from
mssonicbld:cherry/202505/16936
Aug 8, 2025
Merged

[action] [PR:16936] [platform] Fix the test_status_led error in case if the chassis led is not controllable#20143
mssonicbld merged 1 commit intosonic-net:202505from
mssonicbld:cherry/202505/16936

Conversation

@mssonicbld
Copy link
Copy Markdown
Collaborator

Description of PR

Summary: Fix the test_status_led error in case if the chassis led is not controllable

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

The platform_tests/api/test_chassis.py::test_status_led testcase code logic assumes that the chassis main led is always controllable.

But for some of the Cisco devices this test logic:

status_led = duthost.facts.get("chassis").get("status_led")

always returns None, which means that the chassis led is not controllable. That is why I introduce such change - to assume on default that the chassis led is not controllable.

How did you do it?

Change the led_controllable = False variable value.

How did you verify/test it?

Run the platform_tests/api/test_chassis.py.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

…s not controllable (sonic-net#16936)

Signed-off-by: vhlushko <vhlushko@cisco.com>
@mssonicbld
Copy link
Copy Markdown
Collaborator Author

Original PR: #16936

@mssonicbld
Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld mssonicbld merged commit b56aa9d into sonic-net:202505 Aug 8, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants