[platform] Fix the test_status_led error in case if the chassis led is not controllable#16936
Merged
kevinskwang merged 1 commit intosonic-net:masterfrom Aug 8, 2025
Conversation
…s not controllable Signed-off-by: vhlushko <[email protected]>
Collaborator
|
/azp run |
The committers listed above are authorized under a signed CLA. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Need to cherry-pick this to the 202405 branch as well. |
bpar9
approved these changes
Feb 12, 2025
Contributor
Author
|
@bpar9 could you please merge? |
|
@prgeor - could you review this? |
Contributor
Author
|
@bpar9 could you please put a label |
Contributor
Author
|
@prgeor - could you please review this? |
2 similar comments
Contributor
Author
|
@prgeor - could you please review this? |
Contributor
Author
|
@prgeor - could you please review this? |
Contributor
|
@judyjoseph to review |
Contributor
Author
|
@judyjoseph kind reminder |
1 similar comment
Contributor
Author
|
@judyjoseph kind reminder |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 8, 2025
…s not controllable (sonic-net#16936) Signed-off-by: vhlushko <[email protected]>
Collaborator
|
Cherry-pick PR to 202505: #20143 |
9 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Aug 8, 2025
…s not controllable (#16936) Signed-off-by: vhlushko <[email protected]>
mssonicbld
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
ashutosh-agrawal
pushed a commit
to ashutosh-agrawal/sonic-mgmt
that referenced
this pull request
Aug 14, 2025
…s not controllable (sonic-net#16936) Signed-off-by: vhlushko <[email protected]>
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 15, 2025
…s not controllable (sonic-net#16936) Signed-off-by: vhlushko <[email protected]>
Collaborator
|
Cherry-pick PR to 202411: #20262 |
9 tasks
kevinskwang
pushed a commit
that referenced
this pull request
Aug 15, 2025
…s not controllable (#16936) (#20262) Signed-off-by: vhlushko <[email protected]> Co-authored-by: Vadym Hlushko <[email protected]>
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
…s not controllable (sonic-net#16936) Signed-off-by: vhlushko <[email protected]>
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…s not controllable (sonic-net#16936) Signed-off-by: vhlushko <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…s not controllable (sonic-net#16936) Signed-off-by: vhlushko <[email protected]> Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…s not controllable (sonic-net#16936) Signed-off-by: vhlushko <[email protected]> Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…s not controllable (sonic-net#16936) Signed-off-by: vhlushko <[email protected]> Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…s not controllable (sonic-net#16936) Signed-off-by: vhlushko <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…s not controllable (sonic-net#16936) Signed-off-by: vhlushko <[email protected]> Signed-off-by: Guy Shemesh <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…s not controllable (sonic-net#16936) Signed-off-by: vhlushko <[email protected]> Signed-off-by: Yael Tzur <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
…s not controllable (sonic-net#16936) Signed-off-by: vhlushko <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Fix the test_status_led error in case if the chassis led is not controllable
Type of change
Back port request
Approach
What is the motivation for this PR?
The platform_tests/api/test_chassis.py::test_status_led testcase code logic assumes that the chassis main led is always controllable.
But for some of the Cisco devices this test logic:
always returns
None, which means that the chassis led is not controllable. That is why I introduce such change - to assume on default that the chassis led is not controllable.How did you do it?
Change the
led_controllable = Falsevariable value.How did you verify/test it?
Run the
platform_tests/api/test_chassis.py.Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation