Handle Multi-port portchannel member case in ECMP member flap TC by deepak-singhal0408 · Pull Request #20125 · sonic-net/sonic-mgmt

deepak-singhal0408 · 2025-08-07T20:55:32Z

Description of PR

Summary:
Fixes #17887

Type of change

Back port request

Approach

What is the motivation for this PR?

This fixes issue mentioned in #17887.
For pizza box DUTs, multi-port portchannel scenario was not handled, which caused issue on certain specific topologies.

How did you do it?

Add all members of PORT_CHANNEL (if the port being shutdown is part of PORT_CHANNEL) to the filtered ports list, so that during fib_test, these ports are not randomly picked as src port.

How did you verify/test it?

Verified on t1-lag topology. the testcase passes.
Logs:

07/08/2025 20:31:13 test_fib.test_ecmp_group_member_flap     L0864 INFO   | Shutting down one uplink port.
07/08/2025 20:31:13 test_fib.test_ecmp_group_member_flap     L0869 INFO   | Shutting down port Ethernet0
07/08/2025 20:31:31 test_fib.get_port_and_portchannel_member L0764 INFO   | Port Ethernet0 is a member of port channel PortChannel102, adding all members: ['Ethernet0', 'Ethernet8']
07/08/2025 20:31:31 test_fib.get_port_and_portchannel_member L0773 INFO   | Found PTF port 0 for port channel member Ethernet0
07/08/2025 20:31:31 test_fib.get_port_and_portchannel_member L0773 INFO   | Found PTF port 1 for port channel member Ethernet8
07/08/2025 20:31:31 test_fib.test_ecmp_group_member_flap     L0881 INFO   | Verifying ECMP behavior after member down.
["/root/env-python3/bin/ptf --test-dir ptftests/py3 fib_test.FibTest --platform-dir ptftests --qlen=20000 --platform remote -t 'fib_info_files=['\"'\"'/root/fib_info_dut_test_ecmp_group_member_flap[True-False-1514]_0.txt'\"'\"'];
ptf_test_port_map='\"'\"'/root/ptf_test_port_map.json'\"'\"';ipv4=True;ipv6=False;testbed_mtu=1514;test_balancing=True;ignore_ttl=False;single_fib_for_duts='\"'\"'multiple-fib'\"'\"';switch_type='\"'\"''\"'\"';;
skip_src_ports=[**0, 1]**' --relax --debug info --log-file /tmp/fib_test.ecmp_member_flap.member_down.ipv4.True.ipv6.False.2025-08-07-20:26:22.log --socket-recv-size 16384"], kwargs={"chdir": "/root", "module_ignore_errors": false, "module_async": false}

Any platform specific information?

NA

Supported testbed topology if it's a new test case?

NA

Documentation

mssonicbld · 2025-08-07T20:55:39Z

/azp run

azure-pipelines · 2025-08-07T20:55:52Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-08-07T21:13:01Z

/azp run

azure-pipelines · 2025-08-07T21:13:15Z

Azure Pipelines successfully started running 1 pipeline(s).

tests/fib/test_fib.py

mssonicbld · 2025-08-14T17:41:21Z

/azp run

azure-pipelines · 2025-08-14T17:41:36Z

Azure Pipelines successfully started running 1 pipeline(s).

arista-nwolfe

Thanks for updating, LGTM

deepak-singhal0408 · 2025-08-15T16:28:24Z

/azpw run Azure.sonic-mgmt

mssonicbld · 2025-08-15T16:28:26Z

/AzurePipelines run Azure.sonic-mgmt

azure-pipelines · 2025-08-15T16:28:40Z

Azure Pipelines successfully started running 1 pipeline(s).

…ic-net#20125) This fixes issue mentioned in sonic-net#17887. For pizza box DUTs, multi-port portchannel scenario was not handled, which caused issue on certain specific topologies. How did you do it? Add all members of PORT_CHANNEL (if the port being shutdown is part of PORT_CHANNEL) to the filtered ports list, so that during fib_test, these ports are not randomly picked as src port.

mssonicbld · 2025-08-22T01:25:45Z

Cherry-pick PR to 202505: #20362

) This fixes issue mentioned in #17887. For pizza box DUTs, multi-port portchannel scenario was not handled, which caused issue on certain specific topologies. How did you do it? Add all members of PORT_CHANNEL (if the port being shutdown is part of PORT_CHANNEL) to the filtered ports list, so that during fib_test, these ports are not randomly picked as src port.

…ic-net#20125) This fixes issue mentioned in sonic-net#17887. For pizza box DUTs, multi-port portchannel scenario was not handled, which caused issue on certain specific topologies. How did you do it? Add all members of PORT_CHANNEL (if the port being shutdown is part of PORT_CHANNEL) to the filtered ports list, so that during fib_test, these ports are not randomly picked as src port.

…ic-net#20125) This fixes issue mentioned in sonic-net#17887. For pizza box DUTs, multi-port portchannel scenario was not handled, which caused issue on certain specific topologies. How did you do it? Add all members of PORT_CHANNEL (if the port being shutdown is part of PORT_CHANNEL) to the filtered ports list, so that during fib_test, these ports are not randomly picked as src port. Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>

…ic-net#20125) This fixes issue mentioned in sonic-net#17887. For pizza box DUTs, multi-port portchannel scenario was not handled, which caused issue on certain specific topologies. How did you do it? Add all members of PORT_CHANNEL (if the port being shutdown is part of PORT_CHANNEL) to the filtered ports list, so that during fib_test, these ports are not randomly picked as src port. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…ic-net#20125) This fixes issue mentioned in sonic-net#17887. For pizza box DUTs, multi-port portchannel scenario was not handled, which caused issue on certain specific topologies. How did you do it? Add all members of PORT_CHANNEL (if the port being shutdown is part of PORT_CHANNEL) to the filtered ports list, so that during fib_test, these ports are not randomly picked as src port. Signed-off-by: Aharon Malkin <amalkin@nvidia.com>

…ic-net#20125) This fixes issue mentioned in sonic-net#17887. For pizza box DUTs, multi-port portchannel scenario was not handled, which caused issue on certain specific topologies. How did you do it? Add all members of PORT_CHANNEL (if the port being shutdown is part of PORT_CHANNEL) to the filtered ports list, so that during fib_test, these ports are not randomly picked as src port. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…ic-net#20125) This fixes issue mentioned in sonic-net#17887. For pizza box DUTs, multi-port portchannel scenario was not handled, which caused issue on certain specific topologies. How did you do it? Add all members of PORT_CHANNEL (if the port being shutdown is part of PORT_CHANNEL) to the filtered ports list, so that during fib_test, these ports are not randomly picked as src port.

…ic-net#20125) This fixes issue mentioned in sonic-net#17887. For pizza box DUTs, multi-port portchannel scenario was not handled, which caused issue on certain specific topologies. How did you do it? Add all members of PORT_CHANNEL (if the port being shutdown is part of PORT_CHANNEL) to the filtered ports list, so that during fib_test, these ports are not randomly picked as src port. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…ic-net#20125) This fixes issue mentioned in sonic-net#17887. For pizza box DUTs, multi-port portchannel scenario was not handled, which caused issue on certain specific topologies. How did you do it? Add all members of PORT_CHANNEL (if the port being shutdown is part of PORT_CHANNEL) to the filtered ports list, so that during fib_test, these ports are not randomly picked as src port. Signed-off-by: Yael Tzur <ytzur@nvidia.com>

Fix ECMP Member flap TC

97a3bba

deepak-singhal0408 added this to SONiC Chassis Aug 7, 2025

deepak-singhal0408 added the Request for 202505 branch label Aug 7, 2025

deepak-singhal0408 self-assigned this Aug 7, 2025

deepak-singhal0408 requested a review from prabhataravind August 7, 2025 20:57

fix pre-commit checks

ccabbbc

deepak-singhal0408 requested a review from arlakshm August 7, 2025 22:00

deepak-singhal0408 mentioned this pull request Aug 8, 2025

Skip test_ecmp_group_member_flap test due to github issue #17887 #17903

Closed

11 tasks

rlhui requested a review from arista-nwolfe August 13, 2025 17:29

arista-nwolfe reviewed Aug 13, 2025

View reviewed changes

tests/fib/test_fib.py Outdated Show resolved Hide resolved

Fix the get_port_and_portchannel_members function

79540fa

arista-nwolfe approved these changes Aug 14, 2025

View reviewed changes

rlhui merged commit 4118209 into sonic-net:master Aug 20, 2025
20 checks passed

github-project-automation bot moved this to Done in SONiC Chassis Aug 20, 2025

yejianquan added the Approved for 202505 branch label Aug 22, 2025

mssonicbld added the Created PR to 202505 branch label Aug 22, 2025

mssonicbld mentioned this pull request Aug 22, 2025

[action] [PR:20125] Handle Multi-port portchannel member case in ECMP member flap TC #20362

Merged

11 tasks

mssonicbld added the Included in 202505 branch label Aug 22, 2025

mssonicbld removed the Created PR to 202505 branch label Aug 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle Multi-port portchannel member case in ECMP member flap TC#20125

Handle Multi-port portchannel member case in ECMP member flap TC#20125
rlhui merged 3 commits intosonic-net:masterfrom
deepak-singhal0408:deepsinghal/fix_ecmp_member_flap_tc

deepak-singhal0408 commented Aug 7, 2025

Uh oh!

mssonicbld commented Aug 7, 2025

Uh oh!

azure-pipelines bot commented Aug 7, 2025

Uh oh!

mssonicbld commented Aug 7, 2025

Uh oh!

azure-pipelines bot commented Aug 7, 2025

Uh oh!

Uh oh!

mssonicbld commented Aug 14, 2025

Uh oh!

azure-pipelines bot commented Aug 14, 2025

Uh oh!

arista-nwolfe left a comment

Uh oh!

deepak-singhal0408 commented Aug 15, 2025

Uh oh!

mssonicbld commented Aug 15, 2025

Uh oh!

azure-pipelines bot commented Aug 15, 2025

Uh oh!

Uh oh!

mssonicbld commented Aug 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

deepak-singhal0408 commented Aug 7, 2025

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Aug 7, 2025

Uh oh!

azure-pipelines bot commented Aug 7, 2025

Uh oh!

mssonicbld commented Aug 7, 2025

Uh oh!

azure-pipelines bot commented Aug 7, 2025

Uh oh!

Uh oh!

mssonicbld commented Aug 14, 2025

Uh oh!

azure-pipelines bot commented Aug 14, 2025

Uh oh!

arista-nwolfe left a comment

Choose a reason for hiding this comment

Uh oh!

deepak-singhal0408 commented Aug 15, 2025

Uh oh!

mssonicbld commented Aug 15, 2025

Uh oh!

azure-pipelines bot commented Aug 15, 2025

Uh oh!

Uh oh!

mssonicbld commented Aug 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants