Skip test_ecmp_group_member_flap test due to github issue #17887#17903
Skip test_ecmp_group_member_flap test due to github issue #17887#17903echuawu wants to merge 2 commits intosonic-net:masterfrom
Conversation
…7887 Skip test due to sonic-net#17887 Change-Id: I17376139c8dce51e54bc0081574d2fcfc7518d7d
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@yxieca please review and merge |
yxieca
left a comment
There was a problem hiding this comment.
skip is not encouraged.
Please xfail on the platform you tested.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Updated |
@echuawu - the xfail should be only for the observed platforms, not for any platform |
|
@deepak-singhal0408 - can you pls review and approve? |
|
Hi @echuawu @roy-sror thanks for bringing up this issue.. For #2, could you modify the code to additionally handle skipping the remaining portchannel members, once a po member is picked for shutdown?? For#1, We are ensuring to bring down one of the ECMP member.. the testcase is skipped if there is a single nexthop to default route.. Does your setup contain different set of routes with the same nexthop member as a single path and multipath ECMP? |
|
Btw, I could make the change and create PR by End of this week if you like.. If you want to raise, please go ahead.. We have various vendors running this case, without any issue in different topologies. would like them to continue running this case to catch any regressions.. |
Hi @deepak-singhal0408, I am glad to hear that you could fix the issue by the end of this week. Please attach the PR accordingly. Then I would handle this PR. |
|
sorry for the delay.. here is the PR.. #20125 |
Description of PR
Skip test_ecmp_group_member_flap test due to #17887
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Skip test_ecmp_group_member_flap test due to #17887
How did you do it?
Add a skip condition
How did you verify/test it?
Run it in local
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation