Skip to content

Skip test_ecmp_group_member_flap test due to github issue #17887#17903

Closed
echuawu wants to merge 2 commits intosonic-net:masterfrom
echuawu:fib_case_skip
Closed

Skip test_ecmp_group_member_flap test due to github issue #17887#17903
echuawu wants to merge 2 commits intosonic-net:masterfrom
echuawu:fib_case_skip

Conversation

@echuawu
Copy link
Contributor

@echuawu echuawu commented Apr 9, 2025

Description of PR

Skip test_ecmp_group_member_flap test due to #17887

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Skip test_ecmp_group_member_flap test due to #17887

How did you do it?

Add a skip condition

How did you verify/test it?

Run it in local

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

…7887

Skip test due to sonic-net#17887

Change-Id: I17376139c8dce51e54bc0081574d2fcfc7518d7d
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu
Copy link
Contributor Author

echuawu commented Apr 9, 2025

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

@yxieca please review and merge

Copy link
Collaborator

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skip is not encouraged.

Please xfail on the platform you tested.

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@echuawu
Copy link
Contributor Author

echuawu commented Jun 10, 2025

skip is not encouraged.

Please xfail on the platform you tested.

Updated

@roy-sror
Copy link
Contributor

skip is not encouraged.
Please xfail on the platform you tested.

Updated

@echuawu - the xfail should be only for the observed platforms, not for any platform

@echuawu
Copy link
Contributor Author

echuawu commented Jul 15, 2025

skip is not encouraged.
Please xfail on the platform you tested.

Updated

@echuawu - the xfail should be only for the observed platforms, not for any platform

Hi @roy-sror , issue #17887 is a common issue, it's not limit to a specific platform.

@roy-sror
Copy link
Contributor

@deepak-singhal0408 - can you pls review and approve?

@deepak-singhal0408
Copy link
Contributor

Hi @echuawu @roy-sror thanks for bringing up this issue..
Instead of skipping,

For #2, could you modify the code to additionally handle skipping the remaining portchannel members, once a po member is picked for shutdown??

For#1, We are ensuring to bring down one of the ECMP member.. the testcase is skipped if there is a single nexthop to default route.. Does your setup contain different set of routes with the same nexthop member as a single path and multipath ECMP?
if no, then this is just a ECMP member down scenario.. right? Shouldnt take longer than a few millisec. for additional buffer, we could change it to 30sec if that helps..

@deepak-singhal0408
Copy link
Contributor

Btw, I could make the change and create PR by End of this week if you like.. If you want to raise, please go ahead..
If you want to skip for now, I recommend to only skip for the platforms on which you are testing...

We have various vendors running this case, without any issue in different topologies. would like them to continue running this case to catch any regressions..

@echuawu
Copy link
Contributor Author

echuawu commented Jul 22, 2025

Btw, I could make the change and create PR by End of this week if you like.. If you want to raise, please go ahead.. If you want to skip for now, I recommend to only skip for the platforms on which you are testing...

We have various vendors running this case, without any issue in different topologies. would like them to continue running this case to catch any regressions..

Hi @deepak-singhal0408, I am glad to hear that you could fix the issue by the end of this week. Please attach the PR accordingly. Then I would handle this PR.

@deepak-singhal0408
Copy link
Contributor

sorry for the delay.. here is the PR.. #20125

@echuawu echuawu closed this Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants