Added multi-asic support missing in interface_util#20078
Merged
rlhui merged 1 commit intosonic-net:masterfrom Aug 13, 2025
Merged
Added multi-asic support missing in interface_util#20078rlhui merged 1 commit intosonic-net:masterfrom
rlhui merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@wenyiz2021 could you help review this PR? thanks |
wenyiz2021
approved these changes
Aug 8, 2025
Contributor
wenyiz2021
left a comment
wenyiz2021
left a comment
There was a problem hiding this comment.
LGTM. this is to avoid attempting to access interface that doesn't belong to the current ASIC.
deepak-singhal0408
approved these changes
Aug 8, 2025
nikamirrr
pushed a commit
to nikamirrr/nmirin-sonic-mgmt
that referenced
this pull request
Aug 20, 2025
A change in test_common/platform/interface_utils.py (get_physical_port_indices) is causing all testcases in platform_tests/api/test_sfp.py::TestSfpApi to error out with the message: TypeError: '<' not supported between instances of 'NoneType' and 'int'
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
A change in test_common/platform/interface_utils.py (get_physical_port_indices) is causing all testcases in platform_tests/api/test_sfp.py::TestSfpApi to error out with the message: TypeError: '<' not supported between instances of 'NoneType' and 'int'
11 tasks
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
A change in test_common/platform/interface_utils.py (get_physical_port_indices) is causing all testcases in platform_tests/api/test_sfp.py::TestSfpApi to error out with the message: TypeError: '<' not supported between instances of 'NoneType' and 'int' Signed-off-by: opcoder0 <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
A change in test_common/platform/interface_utils.py (get_physical_port_indices) is causing all testcases in platform_tests/api/test_sfp.py::TestSfpApi to error out with the message: TypeError: '<' not supported between instances of 'NoneType' and 'int' Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
A change in test_common/platform/interface_utils.py (get_physical_port_indices) is causing all testcases in platform_tests/api/test_sfp.py::TestSfpApi to error out with the message: TypeError: '<' not supported between instances of 'NoneType' and 'int' Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
A change in test_common/platform/interface_utils.py (get_physical_port_indices) is causing all testcases in platform_tests/api/test_sfp.py::TestSfpApi to error out with the message: TypeError: '<' not supported between instances of 'NoneType' and 'int' Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
A change in test_common/platform/interface_utils.py (get_physical_port_indices) is causing all testcases in platform_tests/api/test_sfp.py::TestSfpApi to error out with the message: TypeError: '<' not supported between instances of 'NoneType' and 'int'
prgeor
added a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Jan 16, 2026
… test. (#867) Cherry pick sonic-net/sonic-mgmt#19170 and sonic-net/sonic-mgmt#20078 to 202503.
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
A change in test_common/platform/interface_utils.py (get_physical_port_indices) is causing all testcases in platform_tests/api/test_sfp.py::TestSfpApi to error out with the message: TypeError: '<' not supported between instances of 'NoneType' and 'int' Signed-off-by: Guy Shemesh <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
A change in test_common/platform/interface_utils.py (get_physical_port_indices) is causing all testcases in platform_tests/api/test_sfp.py::TestSfpApi to error out with the message: TypeError: '<' not supported between instances of 'NoneType' and 'int' Signed-off-by: Yael Tzur <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
A change in test_common/platform/interface_utils.py (get_physical_port_indices) is causing all testcases in platform_tests/api/test_sfp.py::TestSfpApi to error out with the message: TypeError: '<' not supported between instances of 'NoneType' and 'int'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
PR for issue #19795
Added multi-asics support missing in PR #19170
A change in test_common/platform/interface_utils.py (get_physical_port_indices)
is causing all testcases in platform_tests/api/test_sfp.py::TestSfpApi to error out with the message:
TypeError: '<' not supported between instances of 'NoneType' and 'int'
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
To add multi-asics support to interface_util.py (get_physical_port_indices)
How did you do it?
In test_common/platform/interface_utils.py (get_physical_port_indices):
Modified logical_intfs to interface_per_asic.
How did you verify/test it?
Tested on a multi-asics voq chassis
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation