Check DOM for only first subport for test_xcvr_info_in_db.py test. by az-pz · Pull Request #19170 · sonic-net/sonic-mgmt

az-pz · 2025-06-24T18:54:04Z

Description of PR

Summary: Check DOM for only first subport for test_xcvr_info_in_db.py test
Fixes # (issue)

Type of change

Back port request

Approach

Add a helper function to get the first subport of logical ports to check for DOM values.

What is the motivation for this PR?

This PR (sonic-net/sonic-platform-daemons#604) changed the way the DOM data is returned for logical ports. After the change, DOM of a logical port is returned only for the first subport of the physical port.

How did you do it?

Added a helper function to get the first subport of logical ports to check for DOM values.
Get first subport for all logical ports.
Check the DOM for only first subports.
Optimize the sonic db query.
Skip the pc/test_retry_count.py::test_retry_count test to pass the CI since the test is always failing and has nothing to do with the current change.

How did you verify/test it?

Ran the tests on SN5600 and SN5640 platforms.

Any platform specific information?

NA

Supported testbed topology if it's a new test case?

No change in testbed topology support.

Documentation

* Get first subport for all logical ports. * Optimize the sonic db query.

mssonicbld · 2025-06-24T18:54:12Z

/azp run

azure-pipelines · 2025-06-24T18:54:18Z

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

…bport

mssonicbld · 2025-06-24T19:07:14Z

/azp run

azure-pipelines · 2025-06-24T19:07:29Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-06-24T22:29:35Z

/azp run

azure-pipelines · 2025-06-24T22:29:49Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull Request Overview

This PR fixes an issue where the DOM is checked only for the first subport of a logical port and optimizes the SONiC DB query for transceiver information. Key changes include:

Updating tests to retrieve and pass the first subport mapping.
Modifying transceiver utility functions to assert DOM sensor information for the first subport.
Adding new helper functions in the platform interface utilities to provide physical-to-logical and first-subport mappings.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
tests/platform_tests/test_xcvr_info_in_db.py	Updated test to use first subport mapping when calling check_transceiver_status
tests/common/platform/transceiver_utils.py	Adjusted DOM sensor checks to look up using first subport instead of logical port
tests/common/platform/interface_utils.py	Added helper functions for physical to logical port mapping and first subport lookup

tests/common/platform/transceiver_utils.py

tests/common/platform/interface_utils.py

mssonicbld · 2025-07-03T18:33:04Z

/azp run

azure-pipelines · 2025-07-03T18:33:18Z

Azure Pipelines successfully started running 1 pipeline(s).

tests/common/plugins/conditional_mark/tests_mark_conditions.yaml

…onic-net#19170) * Check DOM for only first subport for test_xcvr_info_in_db.py test. * Get first subport for all logical ports. * Optimize the sonic db query. * Update assertion error message. * Xfail the failing test_retry_count test.

A change in test_common/platform/interface_utils.py (get_physical_port_indices) is causing all testcases in platform_tests/api/test_sfp.py::TestSfpApi to error out with the message: TypeError: '<' not supported between instances of 'NoneType' and 'int'

…onic-net#19170) * Check DOM for only first subport for test_xcvr_info_in_db.py test. * Get first subport for all logical ports. * Optimize the sonic db query. * Update assertion error message. * Xfail the failing test_retry_count test.

A change in test_common/platform/interface_utils.py (get_physical_port_indices) is causing all testcases in platform_tests/api/test_sfp.py::TestSfpApi to error out with the message: TypeError: '<' not supported between instances of 'NoneType' and 'int'

…onic-net#19170) * Check DOM for only first subport for test_xcvr_info_in_db.py test. * Get first subport for all logical ports. * Optimize the sonic db query. * Update assertion error message. * Xfail the failing test_retry_count test.

A change in test_common/platform/interface_utils.py (get_physical_port_indices) is causing all testcases in platform_tests/api/test_sfp.py::TestSfpApi to error out with the message: TypeError: '<' not supported between instances of 'NoneType' and 'int'

StormLiangMS · 2025-10-31T05:56:13Z

hi @bingwang-ms @az-pz cherrypick failure for 202503, could you do the manual cherrypick?

arista-nwolfe · 2025-11-12T22:35:19Z

hi @bingwang-ms @az-pz cherrypick failure for 202503, could you do the manual cherrypick?

If we do cherry-pick this PR to 202503 please remember to cherry-pick the fix for the issue introduced by this PR - #20078

az-pz · 2025-11-13T18:44:21Z

@StormLiangMS @arista-nwolfe , here's the PR cherry picking this PR and #20078 :
Azure/sonic-mgmt.msft#867

…onic-net#19170) * Check DOM for only first subport for test_xcvr_info_in_db.py test. * Get first subport for all logical ports. * Optimize the sonic db query. * Update assertion error message. * Xfail the failing test_retry_count test. Signed-off-by: opcoder0 <[email protected]>

A change in test_common/platform/interface_utils.py (get_physical_port_indices) is causing all testcases in platform_tests/api/test_sfp.py::TestSfpApi to error out with the message: TypeError: '<' not supported between instances of 'NoneType' and 'int' Signed-off-by: opcoder0 <[email protected]>

…onic-net#19170) * Check DOM for only first subport for test_xcvr_info_in_db.py test. * Get first subport for all logical ports. * Optimize the sonic db query. * Update assertion error message. * Xfail the failing test_retry_count test. Signed-off-by: Guy Shemesh <[email protected]>

A change in test_common/platform/interface_utils.py (get_physical_port_indices) is causing all testcases in platform_tests/api/test_sfp.py::TestSfpApi to error out with the message: TypeError: '<' not supported between instances of 'NoneType' and 'int' Signed-off-by: Guy Shemesh <[email protected]>

…onic-net#19170) * Check DOM for only first subport for test_xcvr_info_in_db.py test. * Get first subport for all logical ports. * Optimize the sonic db query. * Update assertion error message. * Xfail the failing test_retry_count test. Signed-off-by: Aharon Malkin <[email protected]>

A change in test_common/platform/interface_utils.py (get_physical_port_indices) is causing all testcases in platform_tests/api/test_sfp.py::TestSfpApi to error out with the message: TypeError: '<' not supported between instances of 'NoneType' and 'int' Signed-off-by: Aharon Malkin <[email protected]>

…onic-net#19170) * Check DOM for only first subport for test_xcvr_info_in_db.py test. * Get first subport for all logical ports. * Optimize the sonic db query. * Update assertion error message. * Xfail the failing test_retry_count test. Signed-off-by: Guy Shemesh <[email protected]>

A change in test_common/platform/interface_utils.py (get_physical_port_indices) is causing all testcases in platform_tests/api/test_sfp.py::TestSfpApi to error out with the message: TypeError: '<' not supported between instances of 'NoneType' and 'int' Signed-off-by: Guy Shemesh <[email protected]>

…onic-net#19170) * Check DOM for only first subport for test_xcvr_info_in_db.py test. * Get first subport for all logical ports. * Optimize the sonic db query. * Update assertion error message. * Xfail the failing test_retry_count test.

A change in test_common/platform/interface_utils.py (get_physical_port_indices) is causing all testcases in platform_tests/api/test_sfp.py::TestSfpApi to error out with the message: TypeError: '<' not supported between instances of 'NoneType' and 'int'

… test. (#867) Cherry pick sonic-net/sonic-mgmt#19170 and sonic-net/sonic-mgmt#20078 to 202503.

…onic-net#19170) * Check DOM for only first subport for test_xcvr_info_in_db.py test. * Get first subport for all logical ports. * Optimize the sonic db query. * Update assertion error message. * Xfail the failing test_retry_count test. Signed-off-by: Guy Shemesh <[email protected]>

A change in test_common/platform/interface_utils.py (get_physical_port_indices) is causing all testcases in platform_tests/api/test_sfp.py::TestSfpApi to error out with the message: TypeError: '<' not supported between instances of 'NoneType' and 'int' Signed-off-by: Guy Shemesh <[email protected]>

…onic-net#19170) * Check DOM for only first subport for test_xcvr_info_in_db.py test. * Get first subport for all logical ports. * Optimize the sonic db query. * Update assertion error message. * Xfail the failing test_retry_count test. Signed-off-by: Yael Tzur <[email protected]>

A change in test_common/platform/interface_utils.py (get_physical_port_indices) is causing all testcases in platform_tests/api/test_sfp.py::TestSfpApi to error out with the message: TypeError: '<' not supported between instances of 'NoneType' and 'int' Signed-off-by: Yael Tzur <[email protected]>

Check DOM for only first subport for test_xcvr_info_in_db.py test.

ecfbf3e

* Get first subport for all logical ports. * Optimize the sonic db query.

Merge branch 'master' into ariz/update-test-to-check-dom-for-first-su…

2bc7bcc

…bport

mihirpat1 requested a review from Copilot June 24, 2025 21:03

This comment was marked as outdated.

Sign in to view

Update assertion error message.

50816f3

az-pz requested a review from Copilot June 24, 2025 22:36

Copilot AI reviewed Jun 24, 2025

View reviewed changes

tests/common/platform/transceiver_utils.py Show resolved Hide resolved

tests/common/platform/transceiver_utils.py Show resolved Hide resolved

tests/common/platform/interface_utils.py Show resolved Hide resolved

az-pz marked this pull request as ready for review June 25, 2025 17:49

az-pz requested a review from prgeor as a code owner June 25, 2025 17:49

sdszhang added Request for msft-202412 Branch Request for 202505 branch labels Jul 1, 2025

mssonicbld added the Cherry Pick Conflict_msft-202412 label Jul 1, 2025

az-pz mentioned this pull request Jul 2, 2025

(202405) Catch the xcvrd exception returned by get_transceiver_info Azure/sonic-platform-daemons.msft#26

Merged

Xfail the failing test_retry_count test.

6a6e20a

az-pz requested a review from mihirpat1 July 10, 2025 18:23

mihirpat1 reviewed Jul 11, 2025

View reviewed changes

tests/common/plugins/conditional_mark/tests_mark_conditions.yaml Show resolved Hide resolved

mihirpat1 approved these changes Jul 11, 2025

View reviewed changes

prgeor approved these changes Jul 11, 2025

View reviewed changes

prgeor merged commit afa1b04 into sonic-net:master Jul 11, 2025
18 checks passed

az-pz mentioned this pull request Jul 11, 2025

[202412] Check DOM for only first subport for test_xcvr_info_in_db.py test. Azure/sonic-mgmt.msft#529

Merged

r12f added Approved for msft-202412 Branch Created PR to msft-202412 Branch labels Jul 11, 2025

mannytaheri mentioned this pull request Jul 23, 2025

Bug:[chassis] A change in get_physical_port_indices is causing many errors in test_sfp testcases #19795

Closed

mannytaheri added a commit to mannytaheri/sonic-mgmt that referenced this pull request Aug 5, 2025

Added multi-asic support missing in PR sonic-net#19170

25c8feb

mannytaheri mentioned this pull request Aug 5, 2025

Added multi-asic support missing in interface_util #20078

Merged

10 tasks

davidm-arista added the Request for msft-202503 Branch label Oct 30, 2025

mssonicbld added the Cherry Pick Conflict_msft-202503 label Oct 30, 2025

az-pz mentioned this pull request Nov 13, 2025

[202503] Check DOM for only first subport for test_xcvr_info_in_db.py test. Azure/sonic-mgmt.msft#867

Merged

prgeor added a commit to Azure/sonic-mgmt.msft that referenced this pull request Jan 16, 2026

[202503] Check DOM for only first subport for test_xcvr_info_in_db.py…

06e2ed1

… test. (#867) Cherry pick sonic-net/sonic-mgmt#19170 and sonic-net/sonic-mgmt#20078 to 202503.

Conversation

az-pz commented Jun 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Jun 24, 2025

Uh oh!

azure-pipelines bot commented Jun 24, 2025

Uh oh!

mssonicbld commented Jun 24, 2025

Uh oh!

azure-pipelines bot commented Jun 24, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

mssonicbld commented Jun 24, 2025

Uh oh!

azure-pipelines bot commented Jun 24, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Jul 3, 2025

Uh oh!

azure-pipelines bot commented Jul 3, 2025

Uh oh!

Uh oh!

Uh oh!

StormLiangMS commented Oct 31, 2025

Uh oh!

arista-nwolfe commented Nov 12, 2025

Uh oh!

az-pz commented Nov 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

az-pz commented Jun 24, 2025 •

edited

Loading