Skip to content

[action] [PR:19617] Skip some tests when reboot-type is warm-reboot or fast-reboot on smartswitch#19733

Merged
yejianquan merged 1 commit intosonic-net:202505from
mssonicbld:cherry/202505/19617
Jul 25, 2025
Merged

[action] [PR:19617] Skip some tests when reboot-type is warm-reboot or fast-reboot on smartswitch#19733
yejianquan merged 1 commit intosonic-net:202505from
mssonicbld:cherry/202505/19617

Conversation

@mssonicbld
Copy link
Copy Markdown
Collaborator

Description of PR

  1. Use duthost.dut_basic_facts()['ansible_facts']['dut_basic_facts'].get("is_smartswitch") instead of 'duthost.get_facts().get("is_smartswitch")' , because is_smartswitch is defined in dut_basic_facts not in facts
  2. Skip warm-reboot and fast-reboot check test for test_check_reset_status on smartswitch
  3. skip test_bgp_session_interface_down on smartswitch when reboot type is warm-reboot

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
  • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

  1. Fix issue introduced by PR: [smartswitch]: Add is_smartswitch and is_dpu facts to simplify platform-specific test handling #19313
  2. Skip some tests on smartswitch, because smartswitch does not support warm-reboot and fast-reboot

How did you do it?

  1. Use duthost.dut_basic_facts()['ansible_facts']['dut_basic_facts'].get("is_smartswitch") instead of 'duthost.get_facts().get("is_smartswitch")' , because is_smartswitch is defined in dut_basic_facts
  2. Skip warm-reboot and fast-reboot for test_check_reset_status on smartswitch
  3. skip warm-reboot for test_bgp_session_interface_down on smartswitch

How did you verify/test it?

Run the tests on smartswitch

Any platform specific information?

smartswitch

Supported testbed topology if it's a new test case?

Documentation

…rtswitch (sonic-net#19617)

* Skip warm-reboot and fast-reboot for smartswitch

* Skip warm-reboot case for test_bgp_session case on smartswitch
@mssonicbld
Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@yejianquan
Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@yejianquan yejianquan merged commit 9e38913 into sonic-net:202505 Jul 25, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants