Skip some tests when reboot-type is warm-reboot or fast-reboot on smartswitch#19617
Merged
roy-sror merged 2 commits intosonic-net:masterfrom Jul 20, 2025
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JibinBao
force-pushed
the
fix_smartswitch_warm_reboot
branch
from
bf4cb10 to
b34385e
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JibinBao
changed the title
JibinBao
changed the title
nhe-NV
approved these changes
Jul 15, 2025
liushilongbuaa
added
Request for 202505 branch
and removed
Request for 202505 branch
labels
Contributor
Author
|
/azpw run Azure.sonic-mgmt |
Collaborator
|
/AzurePipelines run Azure.sonic-mgmt |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Hi @vvolam, Could you please review it? |
roy-sror
approved these changes
Jul 20, 2025
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 21, 2025
…rtswitch (sonic-net#19617) * Skip warm-reboot and fast-reboot for smartswitch * Skip warm-reboot case for test_bgp_session case on smartswitch
Collaborator
|
Cherry-pick PR to 202505: #19733 |
yejianquan
pushed a commit
that referenced
this pull request
Jul 25, 2025
…rtswitch (#19617) (#19733) Description of PR Use duthost.dut_basic_facts()['ansible_facts']['dut_basic_facts'].get("is_smartswitch") instead of 'duthost.get_facts().get("is_smartswitch")' , because is_smartswitch is defined in dut_basic_facts not in facts Skip warm-reboot and fast-reboot check test for test_check_reset_status on smartswitch skip test_bgp_session_interface_down on smartswitch when reboot type is warm-reboot Summary: Fixes # (issue) Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Approach What is the motivation for this PR? Fix issue introduced by PR: [smartswitch]: Add is_smartswitch and is_dpu facts to simplify platform-specific test handling #19313 Skip some tests on smartswitch, because smartswitch does not support warm-reboot and fast-reboot How did you do it? Use duthost.dut_basic_facts()['ansible_facts']['dut_basic_facts'].get("is_smartswitch") instead of 'duthost.get_facts().get("is_smartswitch")' , because is_smartswitch is defined in dut_basic_facts Skip warm-reboot and fast-reboot for test_check_reset_status on smartswitch skip warm-reboot for test_bgp_session_interface_down on smartswitch How did you verify/test it? Run the tests on smartswitch Any platform specific information? smartswitch Supported testbed topology if it's a new test case?
yejianquan
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Aug 7, 2025
…rtswitch (sonic-net#19617) * Skip warm-reboot and fast-reboot for smartswitch * Skip warm-reboot case for test_bgp_session case on smartswitch
ashutosh-agrawal
pushed a commit
to ashutosh-agrawal/sonic-mgmt
that referenced
this pull request
Aug 14, 2025
…rtswitch (sonic-net#19617) * Skip warm-reboot and fast-reboot for smartswitch * Skip warm-reboot case for test_bgp_session case on smartswitch
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
…rtswitch (sonic-net#19617) * Skip warm-reboot and fast-reboot for smartswitch * Skip warm-reboot case for test_bgp_session case on smartswitch
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…rtswitch (sonic-net#19617) * Skip warm-reboot and fast-reboot for smartswitch * Skip warm-reboot case for test_bgp_session case on smartswitch Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…rtswitch (sonic-net#19617) * Skip warm-reboot and fast-reboot for smartswitch * Skip warm-reboot case for test_bgp_session case on smartswitch Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…rtswitch (sonic-net#19617) * Skip warm-reboot and fast-reboot for smartswitch * Skip warm-reboot case for test_bgp_session case on smartswitch Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…rtswitch (sonic-net#19617) * Skip warm-reboot and fast-reboot for smartswitch * Skip warm-reboot case for test_bgp_session case on smartswitch Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…rtswitch (sonic-net#19617) * Skip warm-reboot and fast-reboot for smartswitch * Skip warm-reboot case for test_bgp_session case on smartswitch
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…rtswitch (sonic-net#19617) * Skip warm-reboot and fast-reboot for smartswitch * Skip warm-reboot case for test_bgp_session case on smartswitch Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…rtswitch (sonic-net#19617) * Skip warm-reboot and fast-reboot for smartswitch * Skip warm-reboot case for test_bgp_session case on smartswitch Signed-off-by: Yael Tzur <ytzur@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
…rtswitch (sonic-net#19617) * Skip warm-reboot and fast-reboot for smartswitch * Skip warm-reboot case for test_bgp_session case on smartswitch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Run the tests on smartswitch
Any platform specific information?
smartswitch
Supported testbed topology if it's a new test case?
Documentation