[snappi-T2] Fix pfcwd/test_pfcwd_actions.py to consider asic value - #19592
Merged
yejianquan merged 1 commit intoJul 31, 2025
Merged
Conversation
Helper method "run_pfc_test" is not passing "asic_value" of the port for enabling/disabling of pfcwd on the dut. This causes config to be not applied for multi-asic devices, where config command needs to be run on asic namespace.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@rraghav-cisco @auspham can you review this change? |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 31, 2025
…onic-net#19592) Description of PR Summary: [snappi-T2] Fix pfcwd/test_pfcwd_actions.py to consider asic value Fixes # sonic-net#19591 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 msft-202405 Approach What is the motivation for this PR? Helper method run_pfc_test is not passing asic_value of the port for enabling/disabling of pfcwd on the dut. This causes config to be not applied for multi-asic devices, where config command needs to be run on asic namespace. And test is failing with No Tx PFCs from DUT after receiving PFCs. How did you do it? Updated helper method to pass asic_value correctly. How did you verify/test it? Test is passing with the fix. co-authorized by: jianquanye@microsoft.com
Collaborator
|
Cherry-pick PR to 202505: #19950 |
Merged
12 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jul 31, 2025
…19592) Description of PR Summary: [snappi-T2] Fix pfcwd/test_pfcwd_actions.py to consider asic value Fixes # #19591 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 msft-202405 Approach What is the motivation for this PR? Helper method run_pfc_test is not passing asic_value of the port for enabling/disabling of pfcwd on the dut. This causes config to be not applied for multi-asic devices, where config command needs to be run on asic namespace. And test is failing with No Tx PFCs from DUT after receiving PFCs. How did you do it? Updated helper method to pass asic_value correctly. How did you verify/test it? Test is passing with the fix. co-authorized by: jianquanye@microsoft.com
mssonicbld
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
12 tasks
Collaborator
|
Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#682 |
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…onic-net#19592) Description of PR Summary: [snappi-T2] Fix pfcwd/test_pfcwd_actions.py to consider asic value Fixes # sonic-net#19591 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 msft-202405 Approach What is the motivation for this PR? Helper method run_pfc_test is not passing asic_value of the port for enabling/disabling of pfcwd on the dut. This causes config to be not applied for multi-asic devices, where config command needs to be run on asic namespace. And test is failing with No Tx PFCs from DUT after receiving PFCs. How did you do it? Updated helper method to pass asic_value correctly. How did you verify/test it? Test is passing with the fix. co-authorized by: jianquanye@microsoft.com Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…onic-net#19592) Description of PR Summary: [snappi-T2] Fix pfcwd/test_pfcwd_actions.py to consider asic value Fixes # sonic-net#19591 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 msft-202405 Approach What is the motivation for this PR? Helper method run_pfc_test is not passing asic_value of the port for enabling/disabling of pfcwd on the dut. This causes config to be not applied for multi-asic devices, where config command needs to be run on asic namespace. And test is failing with No Tx PFCs from DUT after receiving PFCs. How did you do it? Updated helper method to pass asic_value correctly. How did you verify/test it? Test is passing with the fix. co-authorized by: jianquanye@microsoft.com Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…onic-net#19592) Description of PR Summary: [snappi-T2] Fix pfcwd/test_pfcwd_actions.py to consider asic value Fixes # sonic-net#19591 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 msft-202405 Approach What is the motivation for this PR? Helper method run_pfc_test is not passing asic_value of the port for enabling/disabling of pfcwd on the dut. This causes config to be not applied for multi-asic devices, where config command needs to be run on asic namespace. And test is failing with No Tx PFCs from DUT after receiving PFCs. How did you do it? Updated helper method to pass asic_value correctly. How did you verify/test it? Test is passing with the fix. co-authorized by: jianquanye@microsoft.com
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…onic-net#19592) Description of PR Summary: [snappi-T2] Fix pfcwd/test_pfcwd_actions.py to consider asic value Fixes # sonic-net#19591 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 msft-202405 Approach What is the motivation for this PR? Helper method run_pfc_test is not passing asic_value of the port for enabling/disabling of pfcwd on the dut. This causes config to be not applied for multi-asic devices, where config command needs to be run on asic namespace. And test is failing with No Tx PFCs from DUT after receiving PFCs. How did you do it? Updated helper method to pass asic_value correctly. How did you verify/test it? Test is passing with the fix. co-authorized by: jianquanye@microsoft.com Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…onic-net#19592) Description of PR Summary: [snappi-T2] Fix pfcwd/test_pfcwd_actions.py to consider asic value Fixes # sonic-net#19591 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 msft-202405 Approach What is the motivation for this PR? Helper method run_pfc_test is not passing asic_value of the port for enabling/disabling of pfcwd on the dut. This causes config to be not applied for multi-asic devices, where config command needs to be run on asic namespace. And test is failing with No Tx PFCs from DUT after receiving PFCs. How did you do it? Updated helper method to pass asic_value correctly. How did you verify/test it? Test is passing with the fix. co-authorized by: jianquanye@microsoft.com Signed-off-by: Yael Tzur <ytzur@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: [snappi-T2] Fix pfcwd/test_pfcwd_actions.py to consider asic value
Fixes # #19591
Type of change
Back port request
Approach
What is the motivation for this PR?
Helper method
run_pfc_testis not passingasic_valueof the port for enabling/disabling of pfcwd on the dut. This causes config to be not applied for multi-asic devices, where config command needs to be run on asic namespace. And test is failing withNo Tx PFCs from DUT after receiving PFCs.How did you do it?
Updated helper method to pass
asic_valuecorrectly.How did you verify/test it?
Test is passing with the fix.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation