[snappi-T2] Update ecn helpers to use asic_value for fetching config_facts by vkjammala-arista · Pull Request #19589 · sonic-net/sonic-mgmt

vkjammala-arista · 2025-07-14T16:40:11Z

Description of PR

Summary: [snappi-T2] Update ecn helpers to use asic_value for fetching config_facts
Fixes # #19590

Type of change

Back port request

Approach

What is the motivation for this PR?

Couple of ecn config helper methods are not using asic_value (which refers to asic where underlying port belongs to, in case of multi-asic devices) to fetch config_facts, thus causing config_facts to be fetched from linecard namespace (instead of asic namespace) which doesn't have qos config (WRED_PROFILE, BUFFER_PROFILE etc) and causing test failures with Failed to configure WRED/ECN at the DUT.

How did you do it?

Pass asic_value parameter to the config helper methods.

How did you verify/test it?

With the fix test is not hitting Failed to configure WRED/ECN at the DUT

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

…facts Couple of ecn config helper methods are not using asic_value (which refers to asic where underlying port belongs to, in case of multi-asic devices) to fetch config_facts, thus causing config_facts to be fetched from linecard namespace (instead of asic namespace) which doesn't have qos config (WRED_PROFILE, BUFFER_PROFILE etc) and causing test failures with "Failed to configure WRED/ECN at the DUT".

mssonicbld · 2025-07-14T16:40:19Z

/azp run

azure-pipelines · 2025-07-14T16:40:33Z

Azure Pipelines successfully started running 1 pipeline(s).

sdszhang · 2025-07-23T22:12:10Z

@vkjammala-arista @kenneth-arista can you share the test result with 202405 image.

vkjammala-arista · 2025-07-25T07:07:01Z

Hi @sdszhang, test_red_accuracy_with_snappi.py which was failing earlier with

    @pytest.mark.parametrize("multidut_port_info", MULTIDUT_PORT_INFO[MULTIDUT_TESTBED])
    def test_red_accuracy(request,
    ...
    ...
&gt;       ip_pkts_list = run_ecn_test(api=snappi_api,
                                    testbed_config=testbed_config,
                                    port_config_list=port_config_list,
                                    conn_data=conn_graph_facts,
                                    fanout_data=fanout_graph_facts_multidut,
                                    dut_port=snappi_ports[0]['peer_port'],
                                    lossless_prio=lossless_prio,
                                    prio_dscp_map=prio_dscp_map,
                                    iters=num_iterations,
                                    snappi_extra_params=snappi_extra_params)
        ...
        ...
        # Configure WRED/ECN thresholds
        logger.info("Configuring WRED and ECN thresholds")
        config_result = config_wred(host_ans=egress_duthost,
                                    kmin=snappi_extra_params.ecn_params["kmin"],
                                    kmax=snappi_extra_params.ecn_params["kmax"],
                                    pmax=snappi_extra_params.ecn_params["pmax"])
&gt;       pytest_assert(config_result is True, 'Failed to configure WRED/ECN at the DUT')
E       Failed: Failed to configure WRED/ECN at the DUT

With the fix, no failure is seen.

+---------------------------------------------------+------------------------------------------------+----------------------------------------+---------+----------------------------+----------------+---------+
| filename                                          | classname                                      | testname                               | status  | start                      | duration       | message |
+---------------------------------------------------+------------------------------------------------+----------------------------------------+---------+----------------------------+----------------+---------+
| snappi_tests/ecn/test_red_accuracy_with_snappi.py | snappi_tests.ecn.test_red_accuracy_with_snappi | test_red_accuracy[multidut_port_info0] | success | 2025-07-23 15:36:50.704090 | 0:06:15.219039 |         |
| snappi_tests/ecn/test_red_accuracy_with_snappi.py | snappi_tests.ecn.test_red_accuracy_with_snappi | test_red_accuracy[multidut_port_info1] | success | 2025-07-23 15:43:05.924698 | 0:05:03.160649 |         |
| snappi_tests/ecn/test_red_accuracy_with_snappi.py | snappi_tests.ecn.test_red_accuracy_with_snappi | test_red_accuracy[multidut_port_info2] | success | 2025-07-23 15:48:09.087462 | 0:11:06.253588 |         |
+---------------------------------------------------+------------------------------------------------+----------------------------------------+---------+----------------------------+----------------+---------+

07:01:28 snappi_api.warning                       L1426 WARNING| Capture was not stopped for this port Port 0
PASSED                                                                                             [ 33%]
snappi_tests/ecn/test_red_accuracy_with_snappi.py::test_red_accuracy[multidut_port_info1]
--------------------------------------------- live log call ----------------------------------------------
07:06:26 snappi_api.warning                       L1426 WARNING| Capture was not stopped for this port Port 0
PASSED                                                                                             [ 66%]
snappi_tests/ecn/test_red_accuracy_with_snappi.py::test_red_accuracy[multidut_port_info2]
--------------------------------------------- live log call ----------------------------------------------
07:11:24 snappi_api.warning                       L1426 WARNING| Capture was not stopped for this port Port 0
PASSED                                                                                             [100%]                                                                                                             ------------------------------------------- live log teardown --------------------------------------------```

sdszhang

lgtm

…facts (sonic-net#19589) Description of PR Summary: [snappi-T2] Update ecn helpers to use asic_value for fetching config_facts Fixes # sonic-net#19590 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 msft-202405 Approach What is the motivation for this PR? Couple of ecn config helper methods are not using asic_value (which refers to asic where underlying port belongs to, in case of multi-asic devices) to fetch config_facts, thus causing config_facts to be fetched from linecard namespace (instead of asic namespace) which doesn't have qos config (WRED_PROFILE, BUFFER_PROFILE etc) and causing test failures with Failed to configure WRED/ECN at the DUT. How did you do it? Pass asic_value parameter to the config helper methods. How did you verify/test it? With the fix test is not hitting Failed to configure WRED/ECN at the DUT signed-off-by: jianquanye@microsoft.com

mssonicbld · 2025-07-31T00:59:11Z

Cherry-pick PR to 202505: #19951

…facts (#19589) Description of PR Summary: [snappi-T2] Update ecn helpers to use asic_value for fetching config_facts Fixes # #19590 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 msft-202405 Approach What is the motivation for this PR? Couple of ecn config helper methods are not using asic_value (which refers to asic where underlying port belongs to, in case of multi-asic devices) to fetch config_facts, thus causing config_facts to be fetched from linecard namespace (instead of asic namespace) which doesn't have qos config (WRED_PROFILE, BUFFER_PROFILE etc) and causing test failures with Failed to configure WRED/ECN at the DUT. How did you do it? Pass asic_value parameter to the config helper methods. How did you verify/test it? With the fix test is not hitting Failed to configure WRED/ECN at the DUT signed-off-by: jianquanye@microsoft.com

…facts (sonic-net#19589) Description of PR Summary: [snappi-T2] Update ecn helpers to use asic_value for fetching config_facts Fixes # sonic-net#19590 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 msft-202405 Approach What is the motivation for this PR? Couple of ecn config helper methods are not using asic_value (which refers to asic where underlying port belongs to, in case of multi-asic devices) to fetch config_facts, thus causing config_facts to be fetched from linecard namespace (instead of asic namespace) which doesn't have qos config (WRED_PROFILE, BUFFER_PROFILE etc) and causing test failures with Failed to configure WRED/ECN at the DUT. How did you do it? Pass asic_value parameter to the config helper methods. How did you verify/test it? With the fix test is not hitting Failed to configure WRED/ECN at the DUT signed-off-by: jianquanye@microsoft.com

mssonicbld · 2025-08-30T11:23:26Z

Cherry-pick PR to msft-202405: Azure/sonic-mgmt.msft#680

…facts (sonic-net#19589) Description of PR Summary: [snappi-T2] Update ecn helpers to use asic_value for fetching config_facts Fixes # sonic-net#19590 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 msft-202405 Approach What is the motivation for this PR? Couple of ecn config helper methods are not using asic_value (which refers to asic where underlying port belongs to, in case of multi-asic devices) to fetch config_facts, thus causing config_facts to be fetched from linecard namespace (instead of asic namespace) which doesn't have qos config (WRED_PROFILE, BUFFER_PROFILE etc) and causing test failures with Failed to configure WRED/ECN at the DUT. How did you do it? Pass asic_value parameter to the config helper methods. How did you verify/test it? With the fix test is not hitting Failed to configure WRED/ECN at the DUT signed-off-by: jianquanye@microsoft.com

…facts (sonic-net#19589) Description of PR Summary: [snappi-T2] Update ecn helpers to use asic_value for fetching config_facts Fixes # sonic-net#19590 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 msft-202405 Approach What is the motivation for this PR? Couple of ecn config helper methods are not using asic_value (which refers to asic where underlying port belongs to, in case of multi-asic devices) to fetch config_facts, thus causing config_facts to be fetched from linecard namespace (instead of asic namespace) which doesn't have qos config (WRED_PROFILE, BUFFER_PROFILE etc) and causing test failures with Failed to configure WRED/ECN at the DUT. How did you do it? Pass asic_value parameter to the config helper methods. How did you verify/test it? With the fix test is not hitting Failed to configure WRED/ECN at the DUT signed-off-by: jianquanye@microsoft.com Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>

…facts (sonic-net#19589) Description of PR Summary: [snappi-T2] Update ecn helpers to use asic_value for fetching config_facts Fixes # sonic-net#19590 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 msft-202405 Approach What is the motivation for this PR? Couple of ecn config helper methods are not using asic_value (which refers to asic where underlying port belongs to, in case of multi-asic devices) to fetch config_facts, thus causing config_facts to be fetched from linecard namespace (instead of asic namespace) which doesn't have qos config (WRED_PROFILE, BUFFER_PROFILE etc) and causing test failures with Failed to configure WRED/ECN at the DUT. How did you do it? Pass asic_value parameter to the config helper methods. How did you verify/test it? With the fix test is not hitting Failed to configure WRED/ECN at the DUT signed-off-by: jianquanye@microsoft.com Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…facts (sonic-net#19589) Description of PR Summary: [snappi-T2] Update ecn helpers to use asic_value for fetching config_facts Fixes # sonic-net#19590 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 msft-202405 Approach What is the motivation for this PR? Couple of ecn config helper methods are not using asic_value (which refers to asic where underlying port belongs to, in case of multi-asic devices) to fetch config_facts, thus causing config_facts to be fetched from linecard namespace (instead of asic namespace) which doesn't have qos config (WRED_PROFILE, BUFFER_PROFILE etc) and causing test failures with Failed to configure WRED/ECN at the DUT. How did you do it? Pass asic_value parameter to the config helper methods. How did you verify/test it? With the fix test is not hitting Failed to configure WRED/ECN at the DUT signed-off-by: jianquanye@microsoft.com Signed-off-by: Aharon Malkin <amalkin@nvidia.com>

…facts (sonic-net#19589) Description of PR Summary: [snappi-T2] Update ecn helpers to use asic_value for fetching config_facts Fixes # sonic-net#19590 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 msft-202405 Approach What is the motivation for this PR? Couple of ecn config helper methods are not using asic_value (which refers to asic where underlying port belongs to, in case of multi-asic devices) to fetch config_facts, thus causing config_facts to be fetched from linecard namespace (instead of asic namespace) which doesn't have qos config (WRED_PROFILE, BUFFER_PROFILE etc) and causing test failures with Failed to configure WRED/ECN at the DUT. How did you do it? Pass asic_value parameter to the config helper methods. How did you verify/test it? With the fix test is not hitting Failed to configure WRED/ECN at the DUT signed-off-by: jianquanye@microsoft.com Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…facts (sonic-net#19589) Description of PR Summary: [snappi-T2] Update ecn helpers to use asic_value for fetching config_facts Fixes # sonic-net#19590 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 msft-202405 Approach What is the motivation for this PR? Couple of ecn config helper methods are not using asic_value (which refers to asic where underlying port belongs to, in case of multi-asic devices) to fetch config_facts, thus causing config_facts to be fetched from linecard namespace (instead of asic namespace) which doesn't have qos config (WRED_PROFILE, BUFFER_PROFILE etc) and causing test failures with Failed to configure WRED/ECN at the DUT. How did you do it? Pass asic_value parameter to the config helper methods. How did you verify/test it? With the fix test is not hitting Failed to configure WRED/ECN at the DUT signed-off-by: jianquanye@microsoft.com

…facts (sonic-net#19589) Description of PR Summary: [snappi-T2] Update ecn helpers to use asic_value for fetching config_facts Fixes # sonic-net#19590 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 msft-202405 Approach What is the motivation for this PR? Couple of ecn config helper methods are not using asic_value (which refers to asic where underlying port belongs to, in case of multi-asic devices) to fetch config_facts, thus causing config_facts to be fetched from linecard namespace (instead of asic namespace) which doesn't have qos config (WRED_PROFILE, BUFFER_PROFILE etc) and causing test failures with Failed to configure WRED/ECN at the DUT. How did you do it? Pass asic_value parameter to the config helper methods. How did you verify/test it? With the fix test is not hitting Failed to configure WRED/ECN at the DUT signed-off-by: jianquanye@microsoft.com Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>

…facts (sonic-net#19589) Description of PR Summary: [snappi-T2] Update ecn helpers to use asic_value for fetching config_facts Fixes # sonic-net#19590 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 msft-202405 Approach What is the motivation for this PR? Couple of ecn config helper methods are not using asic_value (which refers to asic where underlying port belongs to, in case of multi-asic devices) to fetch config_facts, thus causing config_facts to be fetched from linecard namespace (instead of asic namespace) which doesn't have qos config (WRED_PROFILE, BUFFER_PROFILE etc) and causing test failures with Failed to configure WRED/ECN at the DUT. How did you do it? Pass asic_value parameter to the config helper methods. How did you verify/test it? With the fix test is not hitting Failed to configure WRED/ECN at the DUT signed-off-by: jianquanye@microsoft.com Signed-off-by: Yael Tzur <ytzur@nvidia.com>

…facts (sonic-net#19589) Description of PR Summary: [snappi-T2] Update ecn helpers to use asic_value for fetching config_facts Fixes # sonic-net#19590 Type of change Bug fix Testbed and Framework(new/improvement) New Test case Skipped for non-supported platforms Test case improvement Back port request 202205 202305 202311 202405 202411 202505 msft-202405 Approach What is the motivation for this PR? Couple of ecn config helper methods are not using asic_value (which refers to asic where underlying port belongs to, in case of multi-asic devices) to fetch config_facts, thus causing config_facts to be fetched from linecard namespace (instead of asic namespace) which doesn't have qos config (WRED_PROFILE, BUFFER_PROFILE etc) and causing test failures with Failed to configure WRED/ECN at the DUT. How did you do it? Pass asic_value parameter to the config helper methods. How did you verify/test it? With the fix test is not hitting Failed to configure WRED/ECN at the DUT signed-off-by: jianquanye@microsoft.com

vkjammala-arista mentioned this pull request Jul 14, 2025

Bug: [snappi] snappi_tests/test_dequeue_ecn_with_snappi.py failure with "Failed to configure WRED/ECN at the DUT" #19590

Closed

kenneth-arista moved this to In Progress in SONiC Snappi Jul 17, 2025

kenneth-arista added this to SONiC Snappi Jul 17, 2025

sdszhang moved this from In Progress to To be Merged in SONiC Snappi Jul 30, 2025

sdszhang approved these changes Jul 30, 2025

View reviewed changes

sdszhang added the Request for 202505 branch label Jul 31, 2025

yejianquan merged commit 9ee5f7c into sonic-net:master Jul 31, 2025
11 checks passed

github-project-automation bot moved this from To be Merged to Done in SONiC Snappi Jul 31, 2025

yejianquan added the Approved for 202505 branch label Jul 31, 2025

mssonicbld added the Created PR to 202505 branch label Jul 31, 2025

mssonicbld mentioned this pull request Jul 31, 2025

[action] [PR:19589] [snappi-T2] Update ecn helpers to use asic_value for fetching config_facts #19951

Merged

12 tasks

mssonicbld added Included in 202505 branch and removed Created PR to 202505 branch labels Jul 31, 2025

YatishSVC added the Request for msft-202405 Branch label Aug 29, 2025

yejianquan added the Approved for msft-202405 Branch label Aug 30, 2025

mssonicbld mentioned this pull request Aug 30, 2025

[action] [PR:19589] [snappi-T2] Update ecn helpers to use asic_value for fetching config_facts Azure/sonic-mgmt.msft#680

Merged

12 tasks

mssonicbld added the Created PR to msft-202405 Branch label Aug 30, 2025

mssonicbld added Included in msft-202405 Branch and removed Created PR to msft-202405 Branch labels Aug 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[snappi-T2] Update ecn helpers to use asic_value for fetching config_facts#19589

[snappi-T2] Update ecn helpers to use asic_value for fetching config_facts#19589
yejianquan merged 1 commit intosonic-net:masterfrom
vkjammala-arista:fix-dequeue-ecn-test

vkjammala-arista commented Jul 14, 2025 •

edited

Loading

Uh oh!

mssonicbld commented Jul 14, 2025

Uh oh!

azure-pipelines bot commented Jul 14, 2025

Uh oh!

sdszhang commented Jul 23, 2025 •

edited

Loading

Uh oh!

vkjammala-arista commented Jul 25, 2025 •

edited

Loading

Uh oh!

sdszhang left a comment

Uh oh!

Uh oh!

mssonicbld commented Jul 31, 2025

Uh oh!

mssonicbld commented Aug 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

vkjammala-arista commented Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of PR

Type of change

Back port request

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Uh oh!

mssonicbld commented Jul 14, 2025

Uh oh!

azure-pipelines bot commented Jul 14, 2025

Uh oh!

sdszhang commented Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vkjammala-arista commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sdszhang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mssonicbld commented Jul 31, 2025

Uh oh!

mssonicbld commented Aug 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

vkjammala-arista commented Jul 14, 2025 •

edited

Loading

sdszhang commented Jul 23, 2025 •

edited

Loading

vkjammala-arista commented Jul 25, 2025 •

edited

Loading