[action] [PR:19589] [snappi-T2] Update ecn helpers to use asic_value for fetching config_facts#680
Merged
mssonicbld merged 1 commit intoAzure:202405from Aug 30, 2025
Conversation
…facts <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: [snappi-T2] Update ecn helpers to use asic_value for fetching config_facts Fixes # sonic-net/sonic-mgmt#19590 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202505 - [x] msft-202405 ### Approach #### What is the motivation for this PR? Couple of ecn config helper methods are not using `asic_value` (which refers to asic where underlying port belongs to, in case of multi-asic devices) to fetch config_facts, thus causing config_facts to be fetched from linecard namespace (instead of asic namespace) which doesn't have qos config (WRED_PROFILE, BUFFER_PROFILE etc) and causing test failures with `Failed to configure WRED/ECN at the DUT`. #### How did you do it? Pass `asic_value` parameter to the config helper methods. #### How did you verify/test it? With the fix test is not hitting `Failed to configure WRED/ECN at the DUT` #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
Collaborator
Author
|
Original PR: sonic-net/sonic-mgmt#19589 |
Collaborator
Author
|
/azp run |
12 tasks
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: [snappi-T2] Update ecn helpers to use asic_value for fetching config_facts
Fixes # sonic-net/sonic-mgmt#19590
Type of change
Back port request
Approach
What is the motivation for this PR?
Couple of ecn config helper methods are not using
asic_value(which refers to asic where underlying port belongs to, in case of multi-asic devices) to fetch config_facts, thus causing config_facts to be fetched from linecard namespace (instead of asic namespace) which doesn't have qos config (WRED_PROFILE, BUFFER_PROFILE etc) and causing test failures withFailed to configure WRED/ECN at the DUT.How did you do it?
Pass
asic_valueparameter to the config helper methods.How did you verify/test it?
With the fix test is not hitting
Failed to configure WRED/ECN at the DUTAny platform specific information?
Supported testbed topology if it's a new test case?
Documentation