[action] [PR:18090] [platform_tests/sfp]: Skip getting sfp info for supervisor#19563
Merged
mssonicbld merged 1 commit intosonic-net:202505from Jul 13, 2025
Merged
Conversation
…#18090) PR sonic-net#16573 added some fixtures for getting port information for sfp tests, however when these fixtures run on supervisor nodes, it fails as sfputil is not valid for supervisors. Add a check in these fixtures to skip supervisor nodes Signed-off-by: Liam Kearney <liamkearney@microsoft.com>
8 tasks
Collaborator
Author
|
Original PR: #18090 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #16573 added some fixtures for getting port information for sfp tests, however when these fixtures run on supervisor nodes, it fails as sfputil is not valid for supervisors.
Add a check in these fixtures to skip supervisor nodes
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Tested on nokia 7250 chassis
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation