[platform_tests/sfp]: Skip getting sfp info for supervisor#18090
Merged
judyjoseph merged 1 commit intosonic-net:masterfrom Jul 12, 2025
Merged
Conversation
PR sonic-net#16573 added some fixtures for getting port information for sfp tests, however when these fixtures run on supervisor nodes, it fails as sfputil is not valid for supervisors. Add a check in these fixtures to skip supervisor nodes Signed-off-by: Liam Kearney <liamkearney@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
JibinBao
approved these changes
Apr 23, 2025
arlakshm
approved these changes
May 17, 2025
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 13, 2025
…#18090) PR sonic-net#16573 added some fixtures for getting port information for sfp tests, however when these fixtures run on supervisor nodes, it fails as sfputil is not valid for supervisors. Add a check in these fixtures to skip supervisor nodes Signed-off-by: Liam Kearney <liamkearney@microsoft.com>
Collaborator
|
Cherry-pick PR to 202505: #19563 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jul 13, 2025
PR #16573 added some fixtures for getting port information for sfp tests, however when these fixtures run on supervisor nodes, it fails as sfputil is not valid for supervisors. Add a check in these fixtures to skip supervisor nodes Signed-off-by: Liam Kearney <liamkearney@microsoft.com>
mssonicbld
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Aug 7, 2025
…#18090) PR sonic-net#16573 added some fixtures for getting port information for sfp tests, however when these fixtures run on supervisor nodes, it fails as sfputil is not valid for supervisors. Add a check in these fixtures to skip supervisor nodes Signed-off-by: Liam Kearney <liamkearney@microsoft.com>
ashutosh-agrawal
pushed a commit
to ashutosh-agrawal/sonic-mgmt
that referenced
this pull request
Aug 14, 2025
…#18090) PR sonic-net#16573 added some fixtures for getting port information for sfp tests, however when these fixtures run on supervisor nodes, it fails as sfputil is not valid for supervisors. Add a check in these fixtures to skip supervisor nodes Signed-off-by: Liam Kearney <liamkearney@microsoft.com>
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
…#18090) PR sonic-net#16573 added some fixtures for getting port information for sfp tests, however when these fixtures run on supervisor nodes, it fails as sfputil is not valid for supervisors. Add a check in these fixtures to skip supervisor nodes Signed-off-by: Liam Kearney <liamkearney@microsoft.com>
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…#18090) PR sonic-net#16573 added some fixtures for getting port information for sfp tests, however when these fixtures run on supervisor nodes, it fails as sfputil is not valid for supervisors. Add a check in these fixtures to skip supervisor nodes Signed-off-by: Liam Kearney <liamkearney@microsoft.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…#18090) PR sonic-net#16573 added some fixtures for getting port information for sfp tests, however when these fixtures run on supervisor nodes, it fails as sfputil is not valid for supervisors. Add a check in these fixtures to skip supervisor nodes Signed-off-by: Liam Kearney <liamkearney@microsoft.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…#18090) PR sonic-net#16573 added some fixtures for getting port information for sfp tests, however when these fixtures run on supervisor nodes, it fails as sfputil is not valid for supervisors. Add a check in these fixtures to skip supervisor nodes Signed-off-by: Liam Kearney <liamkearney@microsoft.com> Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…#18090) PR sonic-net#16573 added some fixtures for getting port information for sfp tests, however when these fixtures run on supervisor nodes, it fails as sfputil is not valid for supervisors. Add a check in these fixtures to skip supervisor nodes Signed-off-by: Liam Kearney <liamkearney@microsoft.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…#18090) PR sonic-net#16573 added some fixtures for getting port information for sfp tests, however when these fixtures run on supervisor nodes, it fails as sfputil is not valid for supervisors. Add a check in these fixtures to skip supervisor nodes Signed-off-by: Liam Kearney <liamkearney@microsoft.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…#18090) PR sonic-net#16573 added some fixtures for getting port information for sfp tests, however when these fixtures run on supervisor nodes, it fails as sfputil is not valid for supervisors. Add a check in these fixtures to skip supervisor nodes Signed-off-by: Liam Kearney <liamkearney@microsoft.com> Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…#18090) PR sonic-net#16573 added some fixtures for getting port information for sfp tests, however when these fixtures run on supervisor nodes, it fails as sfputil is not valid for supervisors. Add a check in these fixtures to skip supervisor nodes Signed-off-by: Liam Kearney <liamkearney@microsoft.com> Signed-off-by: Yael Tzur <ytzur@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #16573 added some fixtures for getting port information for sfp tests, however when these fixtures run on supervisor nodes, it fails as sfputil is not valid for supervisors.
Add a check in these fixtures to skip supervisor nodes
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Tested on nokia 7250 chassis
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation