[action] [PR:18934] Fix tests/common/snappi_tests/traffic_generation.py#19384
Merged
mssonicbld merged 1 commit intosonic-net:202505from Jul 3, 2025
Merged
[action] [PR:18934] Fix tests/common/snappi_tests/traffic_generation.py#19384mssonicbld merged 1 commit intosonic-net:202505from
mssonicbld merged 1 commit intosonic-net:202505from
Conversation
reboot call is still using the outdated argument `plt_reboot_ctrl_overwrite` instead of `return_after_reconnect` that was introduced in sonic-net#16031
11 tasks
Collaborator
Author
|
Original PR: #18934 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reboot call is still using the outdated argument
plt_reboot_ctrl_overwriteinstead ofreturn_after_reconnectthat was introduced in #16031Description of PR
Summary: fix snappi_tests/pfc/warm_reboot/test_pfc_pause_lossless_warm_reboot.py failure
Fixes # #18933
Type of change
Back port request
Approach
What is the motivation for this PR?
Test is failing with:
TypeError: reboot() got an unexpected keyword argument 'plt_reboot_ctrl_overwrite'How did you do it?
Passed
return_after_reconnectinstead of removed argumentplt_reboot_ctrl_overwriteinreboot()call ofcommon/snappi_tests/traffic_generation.pyHow did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation