Fix tests/common/snappi_tests/traffic_generation.py#18934
Merged
wangxin merged 1 commit intosonic-net:masterfrom Jun 12, 2025
Merged
Fix tests/common/snappi_tests/traffic_generation.py#18934wangxin merged 1 commit intosonic-net:masterfrom
wangxin merged 1 commit intosonic-net:masterfrom
Conversation
reboot call is still using the outdated argument `plt_reboot_ctrl_overwrite` instead of `return_after_reconnect` that was introduced in sonic-net#16031
The committers listed above are authorized under a signed CLA. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
anders-nexthop
approved these changes
Jun 11, 2025
Contributor
anders-nexthop
left a comment
anders-nexthop
left a comment
There was a problem hiding this comment.
This is a straightforward fix for a simple regression and can be merged right away.
@yxieca for viz
wangxin
approved these changes
Jun 12, 2025
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 3, 2025
reboot call is still using the outdated argument `plt_reboot_ctrl_overwrite` instead of `return_after_reconnect` that was introduced in sonic-net#16031
Collaborator
|
Cherry-pick PR to 202505: #19384 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jul 3, 2025
reboot call is still using the outdated argument `plt_reboot_ctrl_overwrite` instead of `return_after_reconnect` that was introduced in #16031
mssonicbld
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Aug 7, 2025
reboot call is still using the outdated argument `plt_reboot_ctrl_overwrite` instead of `return_after_reconnect` that was introduced in sonic-net#16031
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
reboot call is still using the outdated argument `plt_reboot_ctrl_overwrite` instead of `return_after_reconnect` that was introduced in sonic-net#16031 Signed-off-by: opcoder0 <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
reboot call is still using the outdated argument `plt_reboot_ctrl_overwrite` instead of `return_after_reconnect` that was introduced in sonic-net#16031 Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
reboot call is still using the outdated argument `plt_reboot_ctrl_overwrite` instead of `return_after_reconnect` that was introduced in sonic-net#16031 Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
reboot call is still using the outdated argument `plt_reboot_ctrl_overwrite` instead of `return_after_reconnect` that was introduced in sonic-net#16031 Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
reboot call is still using the outdated argument `plt_reboot_ctrl_overwrite` instead of `return_after_reconnect` that was introduced in sonic-net#16031
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
reboot call is still using the outdated argument `plt_reboot_ctrl_overwrite` instead of `return_after_reconnect` that was introduced in sonic-net#16031 Signed-off-by: Guy Shemesh <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
reboot call is still using the outdated argument `plt_reboot_ctrl_overwrite` instead of `return_after_reconnect` that was introduced in sonic-net#16031 Signed-off-by: Yael Tzur <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
reboot call is still using the outdated argument `plt_reboot_ctrl_overwrite` instead of `return_after_reconnect` that was introduced in sonic-net#16031
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reboot call is still using the outdated argument
plt_reboot_ctrl_overwriteinstead ofreturn_after_reconnectthat was introduced in #16031Description of PR
Summary: fix snappi_tests/pfc/warm_reboot/test_pfc_pause_lossless_warm_reboot.py failure
Fixes # #18933
Type of change
Back port request
Approach
What is the motivation for this PR?
Test is failing with:
TypeError: reboot() got an unexpected keyword argument 'plt_reboot_ctrl_overwrite'How did you do it?
Passed
return_after_reconnectinstead of removed argumentplt_reboot_ctrl_overwriteinreboot()call ofcommon/snappi_tests/traffic_generation.pyHow did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation