[routes] Add sorting vms in announce_routes for t0 and t1#19340
Merged
Blueve merged 1 commit intosonic-net:masterfrom Jul 3, 2025
Merged
[routes] Add sorting vms in announce_routes for t0 and t1#19340Blueve merged 1 commit intosonic-net:masterfrom
Blueve merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Janetxxx
approved these changes
Jul 3, 2025
Blueve
approved these changes
Jul 3, 2025
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 3, 2025
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests
Collaborator
|
Cherry-pick PR to 202505: #19375 |
This was referenced Jul 3, 2025
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#490 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Jul 3, 2025
What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. #19117 #19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests
mssonicbld
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Aug 7, 2025
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests
ashutosh-agrawal
pushed a commit
to ashutosh-agrawal/sonic-mgmt
that referenced
this pull request
Aug 14, 2025
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests Signed-off-by: Yael Tzur <ytzur@nvidia.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
) This PR depend with PR: sonic-net/sonic-linux-kernel#408 Why I did it Intgerate HW-MGMT 7.0030.2300 Changes Work item tracking Microsoft ADO (number only): How I did it Run make integrate-mlnx-hw-mgmt How to verify it Build an image and run tests from "sonic-mgmt".
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect.
#19117
#19041
How did you do it?
Add sorted in vm index to make sure order of vm dict would always be the same
How did you verify/test it?
Run tests
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation