[bgp_scale] Fix announce_routes for t1-isolated topo#19117
Merged
Blueve merged 4 commits intosonic-net:masterfrom Jun 23, 2025
Merged
[bgp_scale] Fix announce_routes for t1-isolated topo#19117Blueve merged 4 commits intosonic-net:masterfrom
Blueve merged 4 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdszhang
approved these changes
Jun 23, 2025
Contributor
sdszhang
left a comment
sdszhang
left a comment
There was a problem hiding this comment.
topo in BGP_SCALE_T1S list looks good to me.
Blueve
previously approved these changes
Jun 23, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Blueve
approved these changes
Jun 23, 2025
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#437 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
Collaborator
|
@yaqiangz PR conflicts with 202505 branch |
mssonicbld
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
11 tasks
Blueve
pushed a commit
that referenced
this pull request
Jul 3, 2025
What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. #19117 #19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests
mssonicbld
added a commit
to mssonicbld/sonic-mgmt.msft
that referenced
this pull request
Jul 3, 2025
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net/sonic-mgmt#19117 sonic-net/sonic-mgmt#19041 #### How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same #### How did you verify/test it? Run tests #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
11 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jul 3, 2025
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests
11 tasks
mssonicbld
added a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Jul 3, 2025
…0 and t1 (#490) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net/sonic-mgmt#19117 sonic-net/sonic-mgmt#19041 #### How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same #### How did you verify/test it? Run tests #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
mssonicbld
pushed a commit
that referenced
this pull request
Jul 3, 2025
What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. #19117 #19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Aug 7, 2025
What is the motivation for this PR? Fix incorrect route announcing in isolated T1 topos How did you do it? For announce_routes.py, update to announce correct routes Announce more routes, details: [doc] Update announce_routes doc for isolated T1 sonic-net#19128 Add support to announce different sets from downstream For test_ipv6_bgp_scale, because T0 and T2 would both announce default routes, but T0s' has the shorter as path. Hence by default there are only default routes from T0s taking effect. In test, after shutdown all T0 neighbor ports, default routes wouldn't disappear, but default routes from T2 would appear. Hence update routes verification here. How did you verify/test it? Run tests
nissampa
pushed a commit
to nissampa/sonic-mgmt_dpu_test
that referenced
this pull request
Aug 7, 2025
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests
ashutosh-agrawal
pushed a commit
to ashutosh-agrawal/sonic-mgmt
that referenced
this pull request
Aug 14, 2025
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
What is the motivation for this PR? Fix incorrect route announcing in isolated T1 topos How did you do it? For announce_routes.py, update to announce correct routes Announce more routes, details: [doc] Update announce_routes doc for isolated T1 sonic-net#19128 Add support to announce different sets from downstream For test_ipv6_bgp_scale, because T0 and T2 would both announce default routes, but T0s' has the shorter as path. Hence by default there are only default routes from T0s taking effect. In test, after shutdown all T0 neighbor ports, default routes wouldn't disappear, but default routes from T2 would appear. Hence update routes verification here. How did you verify/test it? Run tests Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
What is the motivation for this PR? Fix incorrect route announcing in isolated T1 topos How did you do it? For announce_routes.py, update to announce correct routes Announce more routes, details: [doc] Update announce_routes doc for isolated T1 sonic-net#19128 Add support to announce different sets from downstream For test_ipv6_bgp_scale, because T0 and T2 would both announce default routes, but T0s' has the shorter as path. Hence by default there are only default routes from T0s taking effect. In test, after shutdown all T0 neighbor ports, default routes wouldn't disappear, but default routes from T2 would appear. Hence update routes verification here. How did you verify/test it? Run tests Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
What is the motivation for this PR? Fix incorrect route announcing in isolated T1 topos How did you do it? For announce_routes.py, update to announce correct routes Announce more routes, details: [doc] Update announce_routes doc for isolated T1 sonic-net#19128 Add support to announce different sets from downstream For test_ipv6_bgp_scale, because T0 and T2 would both announce default routes, but T0s' has the shorter as path. Hence by default there are only default routes from T0s taking effect. In test, after shutdown all T0 neighbor ports, default routes wouldn't disappear, but default routes from T2 would appear. Hence update routes verification here. How did you verify/test it? Run tests Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
What is the motivation for this PR? Fix incorrect route announcing in isolated T1 topos How did you do it? For announce_routes.py, update to announce correct routes Announce more routes, details: [doc] Update announce_routes doc for isolated T1 sonic-net#19128 Add support to announce different sets from downstream For test_ipv6_bgp_scale, because T0 and T2 would both announce default routes, but T0s' has the shorter as path. Hence by default there are only default routes from T0s taking effect. In test, after shutdown all T0 neighbor ports, default routes wouldn't disappear, but default routes from T2 would appear. Hence update routes verification here. How did you verify/test it? Run tests Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
What is the motivation for this PR? Fix incorrect route announcing in isolated T1 topos How did you do it? For announce_routes.py, update to announce correct routes Announce more routes, details: [doc] Update announce_routes doc for isolated T1 sonic-net#19128 Add support to announce different sets from downstream For test_ipv6_bgp_scale, because T0 and T2 would both announce default routes, but T0s' has the shorter as path. Hence by default there are only default routes from T0s taking effect. In test, after shutdown all T0 neighbor ports, default routes wouldn't disappear, but default routes from T2 would appear. Hence update routes verification here. How did you verify/test it? Run tests
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
What is the motivation for this PR? Fix incorrect route announcing in isolated T1 topos How did you do it? For announce_routes.py, update to announce correct routes Announce more routes, details: [doc] Update announce_routes doc for isolated T1 sonic-net#19128 Add support to announce different sets from downstream For test_ipv6_bgp_scale, because T0 and T2 would both announce default routes, but T0s' has the shorter as path. Hence by default there are only default routes from T0s taking effect. In test, after shutdown all T0 neighbor ports, default routes wouldn't disappear, but default routes from T2 would appear. Hence update routes verification here. How did you verify/test it? Run tests Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
What is the motivation for this PR? Fix incorrect route announcing in isolated T1 topos How did you do it? For announce_routes.py, update to announce correct routes Announce more routes, details: [doc] Update announce_routes doc for isolated T1 sonic-net#19128 Add support to announce different sets from downstream For test_ipv6_bgp_scale, because T0 and T2 would both announce default routes, but T0s' has the shorter as path. Hence by default there are only default routes from T0s taking effect. In test, after shutdown all T0 neighbor ports, default routes wouldn't disappear, but default routes from T2 would appear. Hence update routes verification here. How did you verify/test it? Run tests Signed-off-by: Yael Tzur <ytzur@nvidia.com>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests Signed-off-by: Yael Tzur <ytzur@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
What is the motivation for this PR? Fix incorrect route announcing in isolated T1 topos How did you do it? For announce_routes.py, update to announce correct routes Announce more routes, details: [doc] Update announce_routes doc for isolated T1 sonic-net#19128 Add support to announce different sets from downstream For test_ipv6_bgp_scale, because T0 and T2 would both announce default routes, but T0s' has the shorter as path. Hence by default there are only default routes from T0s taking effect. In test, after shutdown all T0 neighbor ports, default routes wouldn't disappear, but default routes from T2 would appear. Hence update routes verification here. How did you verify/test it? Run tests
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Mar 27, 2026
…19340) What is the motivation for this PR? Below PRs added support to advertise different route sets from BGP neighbors for T0 / T1, it's based on vm index. But loading dict from yml cannot guarantee the sort always be the same. If we re-announce routes or withdraw routes after order changing, the result would be incorrect. sonic-net#19117 sonic-net#19041 How did you do it? Add sorted in vm index to make sure order of vm dict would always be the same How did you verify/test it? Run tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix incorrect route announcing in isolated T1 topos
How did you do it?
How did you verify/test it?
Run tests
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation